Enable incremental-relative-spans by default.#115656
Conversation
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
davidtwco
left a comment
There was a problem hiding this comment.
This seems reasonable to me, we've waited since Jan (~9mths), I don't see any bugs having been bisected to that PR (with the exception of #106571, which should be addressed but is quite minor), it had a FCP in that PR, and there are good incremental performance wins to be had from this.
|
@bors r+ rollup=never |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (55e5c9d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.427s -> 629.551s (0.02%) |
This was enabled on nightly in #84762.
It has been a while, without obvious bugs. It's time to enable it by default for incremental runs.