Turn custom code classes in docs into warning#115914
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 18, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
…isabled when its syntax is used.
GuillaumeGomez
force-pushed
the
turn-custom_code_classes_in_docs-into-warning
branch
from
e81d7af to
c17abf1
Compare
Manishearth
approved these changes
Sep 17, 2023
Member
|
@bors r+ p=2 rollup=maybe this fixes a docs regression |
Collaborator
bors
added
S-waiting-on-bors
notriddle
reviewed
Sep 17, 2023
Co-authored-by: Michael Howell <michael@notriddle.com>
Member
|
@bors r+ |
Collaborator
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2023
…ses_in_docs-into-warning, r=Manishearth Turn custom code classes in docs into warning By habit, since it was a new feature gate, I added a check which emitted an error in case the new syntax was used. However, since rustdoc tags parser was accepting *everything*, using the "new" syntax should never ever emit errors. It now emits a warning. Follow-up of rust-lang#110800. cc `@Manishearth` r? `@notriddle`
Member
Author
|
Thanks to the both of you! |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Collaborator
Contributor
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (10b88f8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 634.575s -> 636.108s (0.24%) |
GuillaumeGomez
deleted the
turn-custom_code_classes_in_docs-into-warning
branch
This was referenced Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By habit, since it was a new feature gate, I added a check which emitted an error in case the new syntax was used. However, since rustdoc tags parser was accepting everything, using the "new" syntax should never ever emit errors. It now emits a warning.
Follow-up of #110800.
cc @Manishearth
r? @notriddle