Expand doc comment on MIR validation.#115942
Expand doc comment on MIR validation.#115942cjgillot wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
| //! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type | ||
| //! instanciation do not mess things up (for instance #112332 and earlier instances). | ||
| //! | ||
| //! If a check depends on types, it should go in TypeChecker, otherwise it can go in CfgChecker. |
There was a problem hiding this comment.
You said it's "everything affected by substitution", not just types, right? E.g. if something depends on consts (which could be const generics) it also should go into TypeChecker?
|
think this is waiting on author to reply this comment @rustbot author |
rustbot
added
S-waiting-on-author
| //! statements and terminators... | ||
| //! | ||
| //! TypeChecker is meant to verify MIR types. It is used by the inliner to verify that type | ||
| //! instanciation do not mess things up (for instance #112332 and earlier instances). |
There was a problem hiding this comment.
| //! instanciation do not mess things up (for instance #112332 and earlier instances). | |
| //! instantiation do not mess things up (for instance #112332 and earlier instances). |
typo?
|
@cjgillot I think this just needs some minor wording changes? |
|
@cjgillot I recently noticed that both validators check retags. Is that kind of duplication of the checking logic expected behavior? |
|
☔ The latest upstream changes (presumably #125521) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping from triage: |
alex-semenyuk
added
S-waiting-on-author
|
@cjgillot @rustbot label: +S-inactive |
rustbot
added
the
S-inactive
8 participants
r? @RalfJung