Unify defined_lib_features and lib_features queries#116092
Unify defined_lib_features and lib_features queries#116092bors merged 2 commits intorust-lang:masterfrom
defined_lib_features and lib_features queries#116092Conversation
This comment has been minimized.
This comment has been minimized.
|
committed this and then got in bed, will fix tomorrow @rustbot author |
| } | ||
| FeatureStability::Unstable => { | ||
| features.unstable.insert(symbol, DUMMY_SP); | ||
| } |
There was a problem hiding this comment.
Maybe it could directly be serialized into the crate metadata in this format?
There was a problem hiding this comment.
Seems less beneficial to store a bunch of DUMMY_SP in the metadata. Code is simpler now that cjgillot's comment above is applied.
|
☔ The latest upstream changes (presumably #116688) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot ready |
d221878 to
1e02b0f
Compare
1e02b0f to
2d187d5
Compare
|
@bors r=cjgillot |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8534923): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.57s -> 675.862s (-0.25%) |
Extracts part of #115623 (comment)
I went with also introducing a
FeatureStabilityenum, instead of usingSome(span)to mean stable andNoneto mean unstable.r? @cjgillot