Merged
Conversation
…ental usage of forever unstable things
We weren't accounting for the case where `break` was immediately within the `loop` block.
Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things Some groundwork for being able to work on rust-lang/project-stable-mir#27 at all r? `@spastorino`
Anonymize binders for `refining_impl_trait` check We're naively using the equality impl for `ty::Clause` in the refinement check, which is okay *except* for binders, which carry some information about where they come from in the AST. Those locations are not gonna be equal between traits and impls, so anonymize those clauses so that this doesn't matter. Fixes rust-lang#116135
…-async-function-in-main, r=wesleywiser Add test for `const async fn` This adds a test for rust-lang#102796
…rrors
Add context to `let: Ty = loop { break };`
We weren't accounting for the case where `break` was immediately within the `loop` block.
rustbot
added
A-meta
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 376f3f0590 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Sep 27, 2023
Collaborator
|
Finished benchmarking commit (085acd0): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.749s -> 632.103s (0.37%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
refining_impl_traitcheck #116149 (Anonymize binders forrefining_impl_traitcheck)const async fn#116178 (Add test forconst async fn)let: Ty = loop { break };#116187 (Add context tolet: Ty = loop { break };)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup