Update x.ps1#116590
Update x.ps1#116590Aksh-Raizada wants to merge 1 commit intorust-lang:masterfrom Aksh-Raizada:master
Conversation
-Used a more descriptive variable name for $xpy_args ($xpyArgs or $pythonScriptArgs is more descriptive.) -Added a comment to the Invoke-Application() function to explain why the $handle variable is cached. -Used a more descriptive error message in the <span class="math-inline">msg\ variable. -Added a link to the Python documentation in the help: section of the error message.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
kadiwa4
left a comment
kadiwa4
left a comment
There was a problem hiding this comment.
The comment in Invoke-Application and the Python link were already there.
| # Start-Process for some reason splits arguments on spaces. (Isn't powershell supposed to be simpler than bash?) | ||
| # Double-quote all the arguments so it doesn't do that. | ||
| $xpy_args = @("""$xpy""") | ||
| $pythonScriptArgs = @("$($PSScriptRoot)\x.py") |
There was a problem hiding this comment.
Does that work when there's a space in the value of $PSScriptRoot?
And why did you remove the comment?
|
Why change the number of spaces to indent by? This seems like unnecessary churn and obscures the actual changes. |
| $msg = "${PSCommandPath}: error: did not find python installed`n" | ||
| $msg = "${PSCommandPath}: error: could not find a compatible Python installation`n" |
There was a problem hiding this comment.
This just seems like a longer way to say the exact same thing, no? Personally I'd prefer to keep the succinct version unless there's something more actionable to add.
ChrisDenton
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #117071) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing due to lack of activity. If you'd like to continue working on this please reopen before pushing any new commits. |
6 participants
-Used a more descriptive variable name for $xpy_args ($xpyArgs or $pythonScriptArgs is more descriptive.)
-Added a comment to the Invoke-Application() function to explain why the $handle variable is cached.
-Used a more descriptive error message in the msg\ variable.
-Added a link to the Python documentation in the help: section of the error message.