Add (checked_)norem_div methods for integer types#116632
Closed
newpavlov wants to merge 1 commit intorust-lang:masterfrom
Closed
Add (checked_)norem_div methods for integer types#116632newpavlov wants to merge 1 commit intorust-lang:masterfrom
(checked_)norem_div methods for integer types#116632newpavlov wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
newpavlov
force-pushed
the
checked_norem_div
branch
from
e1add59 to
83e444a
Compare
jswrenn
reviewed
Oct 11, 2023
Member
|
@rustbot label +T-libs-api -T-libs |
rustbot
added
T-libs-api
Contributor
Author
|
@joshtriplett ping |
Member
|
r? libs |
rustbot
added
the
T-libs
Member
|
This needs an ACP prior to landing for the new unstable API surface area. |
Mark-Simulacrum
added
S-waiting-on-author
newpavlov
force-pushed
the
checked_norem_div
branch
from
83e444a to
9c8317e
Compare
newpavlov
changed the title
checked_norem_div method for integer types(checked_)norem_div methods for integer types
This comment has been minimized.
This comment has been minimized.
newpavlov
force-pushed
the
checked_norem_div
branch
from
9c8317e to
7d7c470
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
newpavlov
force-pushed
the
checked_norem_div
branch
from
cd9d3e0 to
3864171
Compare
This comment has been minimized.
This comment has been minimized.
newpavlov
force-pushed
the
checked_norem_div
branch
from
3864171 to
b5ed5d0
Compare
Contributor
Author
|
The ACP was created back in February, so I think the |
Dylan-DPC
added
S-waiting-on-ACP
Collaborator
|
☔ The latest upstream changes (presumably #135760) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
May 30, 2025
…ngjubilee Implement ((un)checked_)exact_div methods for integers tracking issue: rust-lang#139911 I see that there might still be some bikeshedding to be done, so if people want changes to this implementation, I'm happy to make those. I did also see that there was a previous attempt at this PR (rust-lang#116632), but I'm not sure why it got closed.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
May 30, 2025
…ngjubilee Implement ((un)checked_)exact_div methods for integers tracking issue: rust-lang#139911 I see that there might still be some bikeshedding to be done, so if people want changes to this implementation, I'm happy to make those. I did also see that there was a previous attempt at this PR (rust-lang#116632), but I'm not sure why it got closed.
rust-timer
added a commit
that referenced
this pull request
May 31, 2025
Rollup merge of #141237 - Qelxiros:139911-exact-div, r=workingjubilee Implement ((un)checked_)exact_div methods for integers tracking issue: #139911 I see that there might still be some bikeshedding to be done, so if people want changes to this implementation, I'm happy to make those. I did also see that there was a previous attempt at this PR (#116632), but I'm not sure why it got closed.
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 3, 2025
…ngjubilee Implement ((un)checked_)exact_div methods for integers tracking issue: rust-lang#139911 I see that there might still be some bikeshedding to be done, so if people want changes to this implementation, I'm happy to make those. I did also see that there was a previous attempt at this PR (rust-lang#116632), but I'm not sure why it got closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods will be useful in cases when we need to ensure that numbers can be divided without remainder.
If the changes are good for inclusion, I will create a tracking issue for the feature.
ACP: rust-lang/libs-team#337