core::net: Rename parse_ascii() fns to from_bytes()

[Turbo87]

We are operating on u8 (aka. byte) values here. ASCII only allows values from 0-127.

This would also be consistent with the naming of OsStr::from_bytes().

Related:

• Tracking Issue for addr_parse_ascii feature #101035
• Support parsing IP addresses from a byte string #94890
• ACP: Add FromByteStr trait with blanket impl FromStr libs-team#287
• https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/addr_parse_ascii.20feature/near/398650220

[rustbot]

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

[cuviper]

We are operating on u8 (aka. byte) values here. ASCII only allows values from 0-127.

Are any non-ASCII bytes actually accepted Ok though?

This would also be consistent with the naming of OsStr::from_bytes().

That's an infallible conversion, truly accepting any bytes.

Anyway, I think this changes posture enough that it needs to be an API decision, especially given that there's a proposed generalization in play at rust-lang/libs-team#287.

@rustbot label -T-libs +T-libs-api
r? libs-api

[Turbo87]

Are any non-ASCII bytes actually accepted Ok though?

fair point, I guess... 🤔

[jmillikin]

It seems confusing for IpAddr::from_bytes(&[58, 58, 48, 49]) and IpAddr::from([58, 58, 48, 49]) to have different behavior .

[scottmcm]

When I see "from bytes" I think https://doc.rust-lang.org/std/primitive.u32.html#method.from_ne_bytes, not anything related to parsing. So I think it needs more in the name to clarify the intent of the bytes.