Add some additional warnings for duplicated diagnostic items#117742
Conversation
|
@compiler-errors Is there anything I can do to move this forward? |
|
☔ The latest upstream changes (presumably #117875) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
left a comment
There was a problem hiding this comment.
r=me once it's rebased, sorry for the review delay
This commit adds warnings if a user supplies several diagnostic options where we can only apply one of them. We explicitly warn about ignored options here. In addition a small test for these warnings is added.
0b34410 to
10538d4
Compare
|
@bors r+ |
|
@weiznich: 🔑 Insufficient privileges: Not in reviewers |
|
No worries for taking time to review changes. It was just meant to be a little reminder |
This comment was marked as outdated.
This comment was marked as outdated.
|
@bors r+ |
This comment was marked as outdated.
This comment was marked as outdated.
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (547ace8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.978s -> 676.499s (0.08%) |
This commit adds warnings if a user supplies several diagnostic options where we can only apply one of them. We explicitly warn about ignored options here. In addition a small test for these warnings is added.
r? @compiler-errors
For now that's the last PR to improve the warnings generated by misused
#[diagnostic::on_unimplemented]attributes. I'm not sure what needs to be done next to move this closer to stabilization.