Add VarDebugInfo to Stable MIR#117972
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 22, 2023
Merged
Conversation
Collaborator
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
Collaborator
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a |
Contributor
|
r? celinval I created rust-lang/team#1119 to hopefully fix the assignment. |
Collaborator
|
☔ The latest upstream changes (presumably #118023) made this pull request unmergeable. Please resolve the merge conflicts. |
ouz-a
force-pushed
the
stable_debuginfo
branch
from
2a5380a to
965f46b
Compare
Contributor
|
@bors r+ rollup Awesome! Thanks |
Contributor
Author
|
I don't think that worked 😅 |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Nov 21, 2023
Add VarDebugInfo to Stable MIR Previously we omitted `VarDebugInfo` because we didn't have `Projection` now that rust-lang#117517 is merged it's possible to add `VarDebugInfo` information in `Body`. This PR adds stable version of the `VarDebugInfo` to `Body` r? `@celinval`
Collaborator
|
☔ The latest upstream changes (presumably #118015) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
ouz-a
force-pushed
the
stable_debuginfo
branch
from
965f46b to
d0dd19a
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 21, 2023
Add VarDebugInfo to Stable MIR Previously we omitted `VarDebugInfo` because we didn't have `Projection` now that rust-lang#117517 is merged it's possible to add `VarDebugInfo` information in `Body`. This PR adds stable version of the `VarDebugInfo` to `Body` r? `@celinval`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 21, 2023
Add VarDebugInfo to Stable MIR Previously we omitted `VarDebugInfo` because we didn't have `Projection` now that rust-lang#117517 is merged it's possible to add `VarDebugInfo` information in `Body`. This PR adds stable version of the `VarDebugInfo` to `Body` r? ``@celinval``
This was referenced Nov 21, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#117972 (Add VarDebugInfo to Stable MIR) - rust-lang#118109 (rustdoc-search: simplify `checkPath` and `sortResults`) - rust-lang#118110 (Document `DefiningAnchor` a bit more) - rust-lang#118112 (Don't ICE when ambiguity is found when selecting `Index` implementation in typeck) - rust-lang#118135 (Remove quotation from filename in stable_mir) Failed merges: - rust-lang#118012 (Add support for global allocation in smir) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 22, 2023
Rollup merge of rust-lang#117972 - ouz-a:stable_debuginfo, r=celinval Add VarDebugInfo to Stable MIR Previously we omitted `VarDebugInfo` because we didn't have `Projection` now that rust-lang#117517 is merged it's possible to add `VarDebugInfo` information in `Body`. This PR adds stable version of the `VarDebugInfo` to `Body` r? ```@celinval```
RalfJung
reviewed
Mar 23, 2024
| } | ||
|
|
||
| #[derive(Clone, Debug, Eq, PartialEq)] | ||
| pub struct ConstOperand { |
Member
There was a problem hiding this comment.
This adds ConstOperand even though Constant already exists -- but those are the same type! In rustc itself, mir::Constant got renamed to mir::ConstOperand, smir just never followed suit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we omitted
VarDebugInfobecause we didn't haveProjectionnow that #117517 is merged it's possible to addVarDebugInfoinformation inBody. This PR adds stable version of theVarDebugInfotoBodyr? @celinval