Rollup of 8 pull requests#118293
Closed
GuillaumeGomez wants to merge 22 commits intorust-lang:masterfrom
Closed
Conversation
`Option::unwrap` is called on the next line.
And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
…_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
remove unused pub fns This removes some unused `pub fn`; also fixes few obsoleted fn names or added fixmes with reminders to update them.
rustc_lint: address latent TODO See individual commits.
Remove `HirId` from `QPath::LangItem` Remove `HirId` from `QPath::LangItem`, since there was only *one* use-case (`ObligationCauseCode::AwaitableExpr`), which we can instead recover by walking the HIR tree.
resolve: Avoid clones of `MacroData` And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
Use `is_{some,ok}_and` more in the compiler
slightly more fluent-reading code
…c, r=fmease
`is_{some,ok}_and` for rustdoc
slightly more fluent-reading code
r? fmease
…GuillaumeGomez rustdoc-search: clean up some DOM code
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ p=10 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Contributor
bors
added
S-waiting-on-author
Contributor
|
No need to wait for that one to be r+'d, probably best to just open a new rollup without that one |
Member
Author
|
Ok, thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
mir::Const::from_anon_const#116446 (Yeetmir::Const::from_anon_const)HirIdfromQPath::LangItem#118199 (RemoveHirIdfromQPath::LangItem)MacroData#118272 (resolve: Avoid clones ofMacroData)is_{some,ok}_andmore in the compiler #118288 (Useis_{some,ok}_andmore in the compiler)is_{some,ok}_andfor rustdoc #118289 (is_{some,ok}_andfor rustdoc)Failed merges:
ObligationCauseCodecleanups #118201 (MiscellaneousObligationCauseCodecleanups)hir().local_def_id_to_hir_id()->tcx.local_def_id_to_hir_id()cleanup #118256 (rustc:hir().local_def_id_to_hir_id()->tcx.local_def_id_to_hir_id()cleanup)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup