rustdoc: Remove space from fake-variadic fn ptr impls#118321
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 27, 2023
Merged
rustdoc: Remove space from fake-variadic fn ptr impls#118321bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
before: `for fn (T₁, T₂, …, Tₙ) -> Ret` after: `for fn(T₁, T₂, …, Tₙ) -> Ret`
Collaborator
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Member
Author
|
r? rustdoc |
notriddle
approved these changes
Nov 26, 2023
Contributor
notriddle
left a comment
notriddle
left a comment
There was a problem hiding this comment.
r? @notriddle
This agrees with rustfmt, so let's go with that.
Try adding a space in fn(, then click "Tools -> Rustfmt".
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 26, 2023
…ke-variadic, r=notriddle rustdoc: Remove space from fake-variadic fn ptr impls before: `for fn (T₁, T₂, …, Tₙ) -> Ret` after: `for fn(T₁, T₂, …, Tₙ) -> Ret` I don't think we usually have spaces there, so it looks weird. cc `@notriddle` since you added the space in rust-lang#98180 (or rather, added the feature with a space included).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#118321 (rustdoc: Remove space from fake-variadic fn ptr impls) - rust-lang#118322 (skip {tidy,compiletest,rustdoc-gui} based tests for `DocTests::Only`) - rust-lang#118325 (Fix Rustdoc search docs link) - rust-lang#118327 (Add my work email to the mailmap) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#118321 (rustdoc: Remove space from fake-variadic fn ptr impls) - rust-lang#118322 (skip {tidy,compiletest,rustdoc-gui} based tests for `DocTests::Only`) - rust-lang#118325 (Fix Rustdoc search docs link) - rust-lang#118327 (Add my work email to the mailmap) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (a191610): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.674s -> 676.103s (0.21%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
for fn (T₁, T₂, …, Tₙ) -> Retafter:
for fn(T₁, T₂, …, Tₙ) -> RetI don't think we usually have spaces there, so it looks weird.
cc @notriddle since you added the space in #98180 (or rather, added the feature with a space included).