Suppress unhelpful diagnostics for unresolved top level attributes by chenyukang · Pull Request #118533 · rust-lang/rust

chenyukang · 2023-12-02T11:55:43Z

Fixes #118455, unresolved top level attribute error didn't imported prelude and already have emitted an error, report builtin macro and attributes error by the way, so check_invalid_crate_level_attr in can ignore them.

Also fixes #89566, fixes #67107.

r? @petrochenkov

petrochenkov · 2023-12-24T11:28:05Z

(I should get to this on new year holidays.)

petrochenkov · 2024-01-17T17:38:50Z

Both this PR and #118511 are hacks, but this one is better.

compiler/rustc_passes/src/check_attr.rs

compiler/rustc_resolve/src/lib.rs

compiler/rustc_resolve/src/macros.rs

chenyukang · 2024-01-27T10:10:46Z

@rustbot ready

compiler/rustc_resolve/src/macros.rs

petrochenkov · 2024-01-27T10:20:53Z

Could we actually land the CannotDetermineMacroResolution deduplication change (#118533 (comment)) before this PR?
It seems like an unambiguous improvement, but the crate-level attribute logic here is more questionable.
@rustbot author

chenyukang · 2024-01-27T13:42:05Z

@rustbot ready

How about this version, seems a small change and suppresses a lot of unnecessary messages.

compiler/rustc_errors/src/lib.rs

compiler/rustc_resolve/src/macros.rs

petrochenkov · 2024-01-27T22:54:50Z

r=me after addressing #118533 (comment) and remaining cleanup (preferably including auto-inserted imports).
@rustbot author

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116677 (References refer to allocated objects) - rust-lang#118533 (Suppress unhelpful diagnostics for unresolved top level attributes) - rust-lang#119991 (Reject infinitely-sized reads from io::Repeat) - rust-lang#120232 (Add support for custom JSON targets when using build-std.) - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120424 (raw pointer metadata API: data address -> data pointer) - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target") - rust-lang#120443 (Fixes footnote handling in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup

chenyukang · 2024-01-29T09:59:14Z

@rustbot ready

petrochenkov · 2024-01-29T13:47:15Z

@bors r+

bors · 2024-01-29T13:47:19Z

📌 Commit 492df34 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2024-01-30T00:37:30Z

⌛ Testing commit 492df34 with merge a369e7c...

…ochenkov Suppress unhelpful diagnostics for unresolved top level attributes Fixes rust-lang#118455, unresolved top level attribute error didn't imported prelude and already have emitted an error, report builtin macro and attributes error by the way, so `check_invalid_crate_level_attr` in can ignore them. Also fixes rust-lang#89566, fixes rust-lang#67107. r? `@petrochenkov`

bors · 2024-01-30T04:52:30Z

💥 Test timed out

rust-log-analyzer · 2024-01-30T05:10:49Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

petrochenkov · 2024-01-30T11:18:19Z

@bors retry

chenyukang · 2024-01-30T13:24:51Z

@bors retry

…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#117906 (Improve display of crate name when hovered) - rust-lang#118533 (Suppress unhelpful diagnostics for unresolved top level attributes) - rust-lang#120293 (Deduplicate more sized errors on call exprs) - rust-lang#120295 (Remove `raw_os_nonzero` feature.) - rust-lang#120310 (adapt test for v0 symbol mangling) - rust-lang#120342 (Remove various `has_errors` or `err_count` uses) - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target") - rust-lang#120445 (Fix some `Arc` allocator leaks) - rust-lang#120475 (Improve error message when `cargo build` is used to build the compiler) - rust-lang#120476 (Remove some unnecessary check logic for lang items in HIR typeck) - rust-lang#120485 (add missing potential_query_instability for keys and values in hashmap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118533 - chenyukang:yukang-fix-118455, r=petrochenkov Suppress unhelpful diagnostics for unresolved top level attributes Fixes rust-lang#118455, unresolved top level attribute error didn't imported prelude and already have emitted an error, report builtin macro and attributes error by the way, so `check_invalid_crate_level_attr` in can ignore them. Also fixes rust-lang#89566, fixes rust-lang#67107. r? `@petrochenkov`

rustbot assigned petrochenkov Dec 2, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2023

chenyukang mentioned this pull request Dec 2, 2023

A nonexistent inner attribute in lib.rs or main.rs breaks every procedural macro used within the entire crate #118455

Closed

chenyukang force-pushed the yukang-fix-118455 branch from e7863df to 6a9456f Compare December 2, 2023 13:47

chenyukang mentioned this pull request Dec 5, 2023

On outer attr not found, avoid knock-down errors #118511

Closed

This comment was marked as resolved.

Sign in to view

chenyukang force-pushed the yukang-fix-118455 branch from 42ef84c to 2c96087 Compare January 4, 2024 12:39

petrochenkov reviewed Jan 17, 2024

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2024

chenyukang force-pushed the yukang-fix-118455 branch 2 times, most recently from c4250ac to ff90b09 Compare January 27, 2024 09:20

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2024

petrochenkov reviewed Jan 27, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024

chenyukang force-pushed the yukang-fix-118455 branch 2 times, most recently from 7de5c65 to c6e936d Compare January 27, 2024 13:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2024

petrochenkov reviewed Jan 27, 2024

View reviewed changes

compiler/rustc_errors/src/lib.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/macros.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2024

matthiaskrgr mentioned this pull request Jan 28, 2024

Rollup of 8 pull requests #120448

Closed

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 29, 2024

Supress unhelpful diagnostics for unresolved top level attributes

492df34

chenyukang force-pushed the yukang-fix-118455 branch from 75f889b to 492df34 Compare January 29, 2024 09:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2024

chenyukang mentioned this pull request Jan 30, 2024

Rollup of 18 pull requests #120491

Merged

GuillaumeGomez mentioned this pull request Jan 30, 2024

Rollup of 11 pull requests #120496

Merged

bors merged commit ee2e9e1 into rust-lang:master Jan 30, 2024

rustbot added this to the 1.77.0 milestone Jan 30, 2024

Uh oh!

Conversation

chenyukang commented Dec 2, 2023 • edited by petrochenkov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Dec 24, 2023

Uh oh!

This comment was marked as resolved.

petrochenkov commented Jan 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenyukang commented Jan 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jan 27, 2024

Uh oh!

chenyukang commented Jan 27, 2024

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jan 27, 2024

Uh oh!

This comment was marked as resolved.

chenyukang commented Jan 29, 2024

Uh oh!

petrochenkov commented Jan 29, 2024

Uh oh!

bors commented Jan 29, 2024

Uh oh!

bors commented Jan 30, 2024

Uh oh!

bors commented Jan 30, 2024

Uh oh!

rust-log-analyzer commented Jan 30, 2024

Uh oh!

petrochenkov commented Jan 30, 2024

Uh oh!

chenyukang commented Jan 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chenyukang commented Dec 2, 2023 •

edited by petrochenkov

Loading