resolve: Use def_kind query to cleanup some code#118620
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 11, 2023
Merged
resolve: Use def_kind query to cleanup some code#118620bors merged 1 commit intorust-lang:masterfrom
def_kind query to cleanup some code#118620bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
petrochenkov
removed
the
S-waiting-on-review
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
[WIP] resolve: Use def_kind query to cleanup some code Follow up to rust-lang#118188. Similar attempts to use queries in resolver resulted in perf regressions in the past, so this needs a perf run first.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (415ba41): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.85s -> 674.542s (0.25%) |
rustbot
removed
the
S-waiting-on-perf
petrochenkov
added
the
S-waiting-on-author
petrochenkov
changed the title
def_kind query to cleanup some code
Contributor
Author
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Dec 11, 2023
Contributor
|
very clean r? compiler-errors @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118620 (resolve: Use `def_kind` query to cleanup some code) - rust-lang#118647 (dump bootstrap shims) - rust-lang#118726 (Do not parenthesize exterior struct lit inside match guards) - rust-lang#118818 (llvm-wrapper: adapt for LLVM API change) - rust-lang#118822 (Extract exhaustiveness into its own crate) - rust-lang#118826 (Edit target doc template to remove email) - rust-lang#118827 (Update table for linker-plugin-lto docs) - rust-lang#118835 (Fix again `rustc_codegen_gcc` tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2023
Rollup merge of rust-lang#118620 - petrochenkov:defeed2, r=compiler-errors resolve: Use `def_kind` query to cleanup some code Follow up to rust-lang#118188. Similar attempts to use queries in resolver resulted in perf regressions in the past, so this needs a perf run first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #118188.
Similar attempts to use queries in resolver resulted in perf regressions in the past, so this needs a perf run first.