Stabilize ip_in_core feature

[faern]

Finally the last stage of rust-lang/rfcs#2832. Since the FCP was just completed with disposition merge, I create the stabilization PR for the ip_in_core feature. Allowing usage of core::net on stable Rust.

The error type core::net::AddrParseError itself becomes stable with this PR. However, core::error::Error is still unstable, so the Error impl for this type is not available on stable rust. Simply because error_in_core is not stable yet, but that should be fine!

[rustbot]

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

[djc]

I wonder if 1.76 has branched yet? Would be nice to get this into 1.77.

[dtolnay]

Thanks!

[dtolnay]

@bors r+

[bors]

📌 Commit 98899b7 has been approved by dtolnay

It is now in the queue for this repository.

[bors]

⌛ Testing commit 98899b7 with merge fc953e7...

[rust-log-analyzer]

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod-inside-fn/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/modules/mod-inside-fn/a", waiting for result
--- stderr -------------------------------
thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[bors]

💔 Test failed - checks-actions

[dtolnay]

@bors retry

[bors]

⌛ Testing commit 98899b7 with merge e87ccb8...

[bors]

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing e87ccb8 to master...

[rust-timer]

Finished benchmarking commit (e87ccb8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.8%]	4
Improvements ✅ (secondary)	-0.5%	[-0.8%, -0.2%]	21
All ❌✅ (primary)	-0.9%	[-0.9%, -0.8%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.6%, -1.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.4%	[-5.4%, -5.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.4%	[-5.4%, -5.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.109s -> 669.342s (-0.11%)
Artifact size: 312.63 MiB -> 312.60 MiB (-0.01%)

[Kobzol]

This is just noise returning back to steady state.