Revert "rustc_lint: Make LintLevelsProvider::current_specs() return &FxIndexMap"#119488
Closed
Enselic wants to merge 1 commit intorust-lang:masterfrom
Closed
Revert "rustc_lint: Make LintLevelsProvider::current_specs() return &FxIndexMap"#119488Enselic wants to merge 1 commit intorust-lang:masterfrom
LintLevelsProvider::current_specs() return &FxIndexMap"#119488Enselic wants to merge 1 commit intorust-lang:masterfrom
Conversation
… `&FxIndexMap`" This reverts commit 231dbbc. It regressed performance. See # 119251. It is not a pure revert because we also need to allow `rustc::potential_query_instability` in one more place now because of the revert.
rustbot
added
S-waiting-on-review
Member
|
I don't think its worth bothering, the regression is tiny and only in extreme stress tests. Running the cachegrind command on a regression does reveal that the additional executed instructions are in |
Contributor
|
I agree with @Nilstrieb. The original PR was in some sense a bugfix, with a tiny regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 231dbbc. It regressed performance. See #119251.
It is not a pure revert because we also need to allow
rustc::potential_query_instabilityin one more place now because of the revert.r? @cjgillot
FWIW, I have tried to find a way in which the loop iterates over more than one lint (which is needed in order for the non-determinism to matter), but so far I have not found a way.