Remove `-Zdump-mir-spanview` by Zalathar · Pull Request #119566 · rust-lang/rust

Zalathar · 2024-01-04T03:47:22Z

The -Zdump-mir-spanview flag was added back in #76074, as a development/debugging aid for the initial work on what would eventually become -Cinstrument-coverage. It causes the compiler to emit an HTML file containing a function's source code, with various spans highlighted based on the contents of MIR.

When the suggestion was made to triage and remove unnecessary -Z flags (Zulip), I noted that this flag could potentially be worth removing, but I wanted to keep it around to see whether I found it useful for my own coverage work.

But when I actually tried to use it, I ran into various issues (e.g. it crashes on tests/coverage/closure.rs). If I can't trust it to work properly without a full overhaul, then instead of diving down a rabbit hole of trying to fix arcane span-handling bugs, it seems better to just remove this obscure old code entirely.

@rustbot label +A-code-coverage

rustbot · 2024-01-04T03:47:30Z

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

Zalathar · 2024-01-04T03:48:38Z

While I was in the area I also noticed some opportunities to simplify pretty.rs by inlining create_dump_file_with_basename and dump_file_basename, but I decided to keep this PR clean and pursue those changes later in a separate PR.

Swatinem

good to see all this code gone. unfortunate that it was not useful with helping/guiding your recent work to improve all that span handling.

Noratrieb

Tried this out once and while it was pretty cute, if it's not useful it should be removed.

Noratrieb · 2024-01-04T12:06:15Z

@bors r=Swatinem,Nilstrieb

bors · 2024-01-04T12:06:18Z

📌 Commit af32054 has been approved by Swatinem,Nilstrieb

It is now in the queue for this repository.

Zalathar · 2024-01-04T12:56:28Z

I might end up having to rebase this after #119531 lands.

compiler-errors · 2024-01-04T22:24:50Z

@bors rollup

…em,Nilstrieb Remove `-Zdump-mir-spanview` The `-Zdump-mir-spanview` flag was added back in rust-lang#76074, as a development/debugging aid for the initial work on what would eventually become `-Cinstrument-coverage`. It causes the compiler to emit an HTML file containing a function's source code, with various spans highlighted based on the contents of MIR. When the suggestion was made to [triage and remove unnecessary `-Z` flags (Zulip)](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60-Z.60.20option.20triage), I noted that this flag could potentially be worth removing, but I wanted to keep it around to see whether I found it useful for my own coverage work. But when I actually tried to use it, I ran into various issues (e.g. it crashes on `tests/coverage/closure.rs`). If I can't trust it to work properly without a full overhaul, then instead of diving down a rabbit hole of trying to fix arcane span-handling bugs, it seems better to just remove this obscure old code entirely. --- `@rustbot` label +A-code-coverage

…em,Nilstrieb Remove `-Zdump-mir-spanview` The `-Zdump-mir-spanview` flag was added back in rust-lang#76074, as a development/debugging aid for the initial work on what would eventually become `-Cinstrument-coverage`. It causes the compiler to emit an HTML file containing a function's source code, with various spans highlighted based on the contents of MIR. When the suggestion was made to [triage and remove unnecessary `-Z` flags (Zulip)](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60-Z.60.20option.20triage), I noted that this flag could potentially be worth removing, but I wanted to keep it around to see whether I found it useful for my own coverage work. But when I actually tried to use it, I ran into various issues (e.g. it crashes on `tests/coverage/closure.rs`). If I can't trust it to work properly without a full overhaul, then instead of diving down a rabbit hole of trying to fix arcane span-handling bugs, it seems better to just remove this obscure old code entirely. --- ``@rustbot`` label +A-code-coverage

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint) - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119420 (Handle ForeignItem as TAIT scope.) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) r? `@ghost` `@rustbot` modify labels: rollup

…em,Nilstrieb Remove `-Zdump-mir-spanview` The `-Zdump-mir-spanview` flag was added back in rust-lang#76074, as a development/debugging aid for the initial work on what would eventually become `-Cinstrument-coverage`. It causes the compiler to emit an HTML file containing a function's source code, with various spans highlighted based on the contents of MIR. When the suggestion was made to [triage and remove unnecessary `-Z` flags (Zulip)](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60-Z.60.20option.20triage), I noted that this flag could potentially be worth removing, but I wanted to keep it around to see whether I found it useful for my own coverage work. But when I actually tried to use it, I ran into various issues (e.g. it crashes on `tests/coverage/closure.rs`). If I can't trust it to work properly without a full overhaul, then instead of diving down a rabbit hole of trying to fix arcane span-handling bugs, it seems better to just remove this obscure old code entirely. --- ```@rustbot``` label +A-code-coverage

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo) - rust-lang#119420 (Handle ForeignItem as TAIT scope.) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119538 (Cleanup error handlers: round 5) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#119034 (Allow coverage tests to ignore test modes, and to enable color in coverage reports) - rust-lang#119148 (Tweak suggestions for bare trait used as a type) - rust-lang#119538 (Cleanup error handlers: round 5) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119583 (Make `intrinsics::assume` const stable) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) - rust-lang#119601 (`Emitter` cleanups) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119566 - Zalathar:remove-spanview, r=Swatinem,Nilstrieb Remove `-Zdump-mir-spanview` The `-Zdump-mir-spanview` flag was added back in rust-lang#76074, as a development/debugging aid for the initial work on what would eventually become `-Cinstrument-coverage`. It causes the compiler to emit an HTML file containing a function's source code, with various spans highlighted based on the contents of MIR. When the suggestion was made to [triage and remove unnecessary `-Z` flags (Zulip)](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60-Z.60.20option.20triage), I noted that this flag could potentially be worth removing, but I wanted to keep it around to see whether I found it useful for my own coverage work. But when I actually tried to use it, I ran into various issues (e.g. it crashes on `tests/coverage/closure.rs`). If I can't trust it to work properly without a full overhaul, then instead of diving down a rabbit hole of trying to fix arcane span-handling bugs, it seems better to just remove this obscure old code entirely. --- ````@rustbot```` label +A-code-coverage

This flag was removed by <rust-lang/rust#119566>.

HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has been removed by rust-lang#119566.

This flag was removed by <rust-lang/rust#119566>.

Don't allow `.html` files in `tests/mir-opt/` HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has been removed by rust-lang#119566.

Rollup merge of rust-lang#120018 - Zalathar:mir-opt-html, r=Nilstrieb Don't allow `.html` files in `tests/mir-opt/` HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has been removed by rust-lang#119566.

Don't create a separate "basename" when naming and opening a MIR dump file These functions were split up by rust-lang#77080, in order to support passing the dump file's “basename” (filename without extension) to the implementation of `-Zdump-mir-spanview`, so that it could be used as a page title. That flag has since been removed (rust-lang#119566), so now there's no particular reason for this code to handle the basename separately from the filename or full path. This PR therefore restores things to (roughly) how they were before rust-lang#77080.

Rollup merge of rust-lang#120038 - Zalathar:dump-path, r=WaffleLapkin Don't create a separate "basename" when naming and opening a MIR dump file These functions were split up by rust-lang#77080, in order to support passing the dump file's “basename” (filename without extension) to the implementation of `-Zdump-mir-spanview`, so that it could be used as a page title. That flag has since been removed (rust-lang#119566), so now there's no particular reason for this code to handle the basename separately from the filename or full path. This PR therefore restores things to (roughly) how they were before rust-lang#77080.

This flag was removed by <rust-lang#119566>.

This flag was removed by <rust-lang/rust#119566>.

Remove -Zdump-mir-spanview

af32054

rustbot assigned TaKO8Ki Jan 4, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) labels Jan 4, 2024

Swatinem approved these changes Jan 4, 2024

View reviewed changes

Noratrieb approved these changes Jan 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 10 pull requests #119602

Closed

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 9 pull requests #119604

Closed

GuillaumeGomez mentioned this pull request Jan 5, 2024

Rollup of 10 pull requests #119611

Closed

compiler-errors mentioned this pull request Jan 5, 2024

Rollup of 10 pull requests #119621

Merged

bors merged commit e74a0cd into rust-lang:master Jan 5, 2024

rustbot added this to the 1.77.0 milestone Jan 5, 2024

Zalathar deleted the remove-spanview branch January 5, 2024 21:20

Zalathar added a commit to Zalathar/rustc-dev-guide that referenced this pull request Jan 16, 2024

Remove outdated references to -Z dump-mir-spanview

7ac332f

This flag was removed by <rust-lang/rust#119566>.

Zalathar mentioned this pull request Jan 16, 2024

Remove outdated references to -Z dump-mir-spanview rust-lang/rustc-dev-guide#1853

Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 16, 2024

Don't allow .html files in tests/mir-opt/

40166c8

HTML files were needed for testing `-Z dump-mir-spanview`, but that flag has been removed by rust-lang#119566.

Zalathar mentioned this pull request Jan 16, 2024

Don't allow .html files in tests/mir-opt/ #120018

Merged

tshepang pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 16, 2024

Remove outdated references to -Z dump-mir-spanview

1dc1152

This flag was removed by <rust-lang/rust#119566>.

Zalathar mentioned this pull request Jan 17, 2024

Don't create a separate "basename" when naming and opening a MIR dump file #120038

Merged

Kobzol pushed a commit to Kobzol/rust that referenced this pull request Dec 30, 2024

Remove outdated references to -Z dump-mir-spanview

3da7613

This flag was removed by <rust-lang#119566>.

bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025

Remove outdated references to -Z dump-mir-spanview

26041cd

This flag was removed by <rust-lang#119566>.

Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jan 3, 2025

Remove outdated references to -Z dump-mir-spanview

7650a97

This flag was removed by <rust-lang/rust#119566>.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `-Zdump-mir-spanview`#119566

Remove `-Zdump-mir-spanview`#119566
bors merged 1 commit intorust-lang:masterfrom
Zalathar:remove-spanview

Zalathar commented Jan 4, 2024

Uh oh!

rustbot commented Jan 4, 2024

Uh oh!

Zalathar commented Jan 4, 2024

Uh oh!

Swatinem left a comment

Uh oh!

Noratrieb left a comment

Uh oh!

Noratrieb commented Jan 4, 2024

Uh oh!

bors commented Jan 4, 2024

Uh oh!

Zalathar commented Jan 4, 2024

Uh oh!

compiler-errors commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Zalathar commented Jan 4, 2024

Uh oh!

rustbot commented Jan 4, 2024

Uh oh!

Zalathar commented Jan 4, 2024

Uh oh!

Swatinem left a comment

Choose a reason for hiding this comment

Uh oh!

Noratrieb left a comment

Choose a reason for hiding this comment

Uh oh!

Noratrieb commented Jan 4, 2024

Uh oh!

bors commented Jan 4, 2024

Uh oh!

Zalathar commented Jan 4, 2024

Uh oh!

compiler-errors commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants