Expand sys/os for UEFI by Ayush1325 · Pull Request #120419 · rust-lang/rust

Ayush1325 · 2024-01-27T11:20:24Z

Implement current_exe() and getcwd()

rustbot · 2024-01-27T11:20:31Z

(rustbot has picked a reviewer for you, use r? to override)

joboet

This is great! Though I wonder about the interaction with the UEFI shell environment, it seems to me like we could/should make use of that, if it exists?

library/std/src/sys/pal/uefi/helpers.rs

library/std/src/sys/pal/uefi/os.rs

Mark-Simulacrum · 2024-02-11T02:04:49Z

cc @nicholasbishop @dvdhrm (target maintainers: https://doc.rust-lang.org/nightly/rustc/platform-support/unknown-uefi.html), needs an approval per https://std-dev-guide.rust-lang.org/policy/target-code.html.

@rustbot author (mark as ready once a +1 has been given in some form from target maintainers)

Ayush1325 · 2024-02-13T11:52:05Z

cc @joshtriplett @Nilstrieb

joshtriplett · 2024-02-16T13:44:25Z

Design seems fine and addresses the concern I had. (This is not a detailed review on the implementation.)

library/std/src/sys/pal/uefi/helpers.rs

- Implement current_exe() - Cache device_path_to_text protocol Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>

Ayush1325 · 2024-03-21T11:05:54Z

@rustbot ready

nicholasbishop · 2024-03-23T18:40:28Z

Approved by target maintainer. (I'm assuming there's no rustbot command I'm supposed to use for this and that a comment is sufficient, let me know if that's wrong.)

workingjubilee · 2024-03-24T05:14:31Z

@bors r=nicholasbishop,workingjubilee

bors · 2024-03-24T05:14:33Z

📌 Commit a2497a9 has been approved by nicholasbishop,workingjubilee

It is now in the queue for this repository.

…ishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#120419 (Expand sys/os for UEFI) - rust-lang#121940 (Mention Register Size in `#[warn(asm_sub_register)]`) - rust-lang#122762 (fix typo of endianness) - rust-lang#122797 (Fix compile of wasm64-unknown-unknown target) - rust-lang#122875 (CFI: Support self_cell-like recursion) - rust-lang#122879 (CFI: Strip auto traits off Virtual calls) - rust-lang#122969 (Simplify an iterator search in borrowck diag) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasbishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

…ishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#120419 (Expand sys/os for UEFI) - rust-lang#121940 (Mention Register Size in `#[warn(asm_sub_register)]`) - rust-lang#122762 (fix typo of endianness) - rust-lang#122797 (Fix compile of wasm64-unknown-unknown target) - rust-lang#122875 (CFI: Support self_cell-like recursion) - rust-lang#122879 (CFI: Strip auto traits off Virtual calls) - rust-lang#122969 (Simplify an iterator search in borrowck diag) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jan 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 27, 2024

Ayush1325 force-pushed the uefi-sys-os branch from 052b053 to bfef16e Compare January 27, 2024 11:26

joboet approved these changes Jan 27, 2024

View reviewed changes

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

library/std/src/sys/pal/uefi/os.rs Show resolved Hide resolved

Ayush1325 force-pushed the uefi-sys-os branch from bfef16e to a5e43be Compare January 27, 2024 15:23

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2024

Ayush1325 force-pushed the uefi-sys-os branch from a5e43be to 3dfa72a Compare February 15, 2024 06:45

Ayush1325 requested a review from joshtriplett February 15, 2024 11:38

nicholasbishop reviewed Feb 16, 2024

View reviewed changes

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

library/std/src/sys/pal/uefi/helpers.rs Show resolved Hide resolved

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

Ayush1325 force-pushed the uefi-sys-os branch from 3dfa72a to 1db9069 Compare February 25, 2024 17:11

nicholasbishop reviewed Mar 2, 2024

View reviewed changes

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

Expand sys/os for UEFI

a2497a9

- Implement current_exe() - Cache device_path_to_text protocol Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>

Ayush1325 force-pushed the uefi-sys-os branch from 1db9069 to a2497a9 Compare March 17, 2024 17:15

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2024

nicholasbishop approved these changes Mar 23, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 24, 2024

Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasb…

101525a

…ishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

workingjubilee mentioned this pull request Mar 24, 2024

Rollup of 9 pull requests #122979

Closed

workingjubilee mentioned this pull request Mar 24, 2024

Rollup of 7 pull requests #122980

Merged

bors merged commit 343c916 into rust-lang:master Mar 24, 2024

rustbot added this to the 1.79.0 milestone Mar 24, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024

Unrolled build for rust-lang#120419

44ddd0f

Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasbishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

Ayush1325 deleted the uefi-sys-os branch March 24, 2024 20:56

RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024

Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasb…

c1579e8

…ishop,workingjubilee Expand sys/os for UEFI - Implement current_exe() and getcwd()

Ayush1325 mentioned this pull request Jul 6, 2024

Tracking Issue for uefi-std #100499

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expand sys/os for UEFI#120419

Expand sys/os for UEFI#120419
bors merged 1 commit intorust-lang:masterfrom
Ayush1325:uefi-sys-os

Ayush1325 commented Jan 27, 2024

Uh oh!

rustbot commented Jan 27, 2024

Uh oh!

joboet left a comment

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum commented Feb 11, 2024

Uh oh!

Ayush1325 commented Feb 13, 2024

Uh oh!

joshtriplett commented Feb 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ayush1325 commented Mar 21, 2024

Uh oh!

nicholasbishop commented Mar 23, 2024

Uh oh!

workingjubilee commented Mar 24, 2024

Uh oh!

bors commented Mar 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

Ayush1325 commented Jan 27, 2024

Uh oh!

rustbot commented Jan 27, 2024

Uh oh!

joboet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mark-Simulacrum commented Feb 11, 2024

Uh oh!

Ayush1325 commented Feb 13, 2024

Uh oh!

joshtriplett commented Feb 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ayush1325 commented Mar 21, 2024

Uh oh!

nicholasbishop commented Mar 23, 2024

Uh oh!

workingjubilee commented Mar 24, 2024

Uh oh!

bors commented Mar 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants