std::thread::available_parallelism merging linux/android/freebsd version by devnexen · Pull Request #120589 · rust-lang/rust

devnexen · 2024-02-02T21:53:02Z

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

rustbot · 2024-02-02T21:53:10Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

library/std/src/sys/pal/unix/thread.rs

m-ou-se · 2024-02-08T10:20:03Z

@bors r+

bors · 2024-02-08T10:20:06Z

📌 Commit 0bfcafd has been approved by m-ou-se

It is now in the queue for this repository.

Nadrieril · 2024-02-08T14:59:37Z

@bors rollup

std::thread::available_parallelism merging linux/android/freebsd version FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#113026 (Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example) - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version) - rust-lang#120590 (Remove unused args from functions) - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages) - rust-lang#120693 (Invert diagnostic lints.) - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`) - rust-lang#120750 (No need to take `ImplTraitContext` by ref) - rust-lang#120765 (Reorder diagnostics API) - rust-lang#120772 (Remove myself from review rotation.) - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint) Failed merges: - rust-lang#120782 (Fix mir pass ICE in the presence of other errors) r? `@ghost` `@rustbot` modify labels: rollup

std::thread::available_parallelism merging linux/android/freebsd version FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#120308 (core/time: avoid divisions in Duration::new) - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version) - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages) - rust-lang#120672 (std::thread update freebsd stack guard handling.) - rust-lang#120693 (Invert diagnostic lints.) - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`) - rust-lang#120806 (Clippy subtree update) - rust-lang#120809 (Use `transmute_unchecked` in `NonZero::new`.) - rust-lang#120817 (Fix more `ty::Error` ICEs in MIR passes) r? `@ghost` `@rustbot` modify labels: rollup

std::thread::available_parallelism merging linux/android/freebsd version FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#120584 (For a rigid projection, recursively look at the self type's item bounds to fix the `associated_type_bounds` feature) - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version) - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages) - rust-lang#120629 (Move some test files) - rust-lang#120846 (Update jobserver-rs to 0.1.28) - rust-lang#120850 (ast_lowering: Fix regression in `use ::{}` imports.) - rust-lang#120853 (Avoid a collection and iteration on empty passes) Failed merges: - rust-lang#120549 (modify alias-relate to also normalize ambiguous opaques) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-02-09T23:58:04Z

@bors r- rollup=never
linking failure
#120861 (comment)

rustbot · 2025-12-02T06:18:25Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

devnexen · 2025-12-02T06:24:22Z

@rustbot ready

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here. a

blyxyas · 2025-12-02T16:25:16Z

Does Clippy have anything to do with this pull request? It has the T-clippy label but I cannot see any related changes.

Enselic · 2025-12-05T17:10:19Z

I've done a fairly careful review of the "diff of the diff" and convinced myself of that the new commit 3ccabb4 is equivalent to the already approved commit.

@bors r=m-ou-se

Does Clippy have anything to do with this pull request? It has the T-clippy label but I cannot see any related changes.

The clippy diff was subsequently force-pushed away.

bors · 2025-12-05T17:10:23Z

📌 Commit 3ccabb4 has been approved by m-ou-se

It is now in the queue for this repository.

devnexen · 2025-12-05T17:26:01Z

Does Clippy have anything to do with this pull request? It has the T-clippy label but I cannot see any related changes.

not at all, in fact my branch was so old I synced badly locally, that is just it :)

std::thread::available_parallelism merging linux/android/freebsd version FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here.

bors · 2025-12-05T19:32:34Z

⌛ Testing commit 3ccabb4 with merge e3f3d59...

rust-log-analyzer · 2025-12-05T20:21:39Z

The job dist-x86_64-freebsd failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] rustc_query_impl test:false 138.695
[RUSTC-TIMING] rustc_driver test:false 8.493
error: linking with `x86_64-unknown-freebsd12-clang` failed: exit status: 1
  |
  = note:  "x86_64-unknown-freebsd12-clang" "-m64" "/tmp/rustcDM5tt9/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/deps/librustc_driver-ea6df38576632e17.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-freebsd/lib/libcompiler_builtins-*.rlib" "-Wl,-Bdynamic" "-lc++" "-lc" "-lrt" "-lutil" "-lexecinfo" "-lkvm" "-lmemstat" "-lkvm" "-lutil" "-lprocstat" "-lrt" "-ldevstat" "-lexecinfo" "-lpthread" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lrt" "-lutil" "-lexecinfo" "-lkvm" "-lmemstat" "-lkvm" "-lutil" "-lprocstat" "-lrt" "-ldevstat" "-L" "/tmp/rustcDM5tt9/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/build/psm-a2b1386b6a4c2e24/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/build/blake3-9525560521e5f270/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/build/rustc_llvm-28f0c305d9ff5368/out" "-L" "/checkout/obj/build/x86_64-unknown-freebsd/llvm/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/deps/rustc_main-1ca440777a4b1988" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-Wl,-z,origin" "-Wl,-rpath,$ORIGIN/../lib"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/local/x86_64-unknown-freebsd12/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-rustc/x86_64-unknown-freebsd/release/deps/librustc_driver-ea6df38576632e17.so: undefined reference to `sched_getaffinity'
          clang: error: linker command failed with exit code 1 (use -v to see invocation)
          
  = note: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified

bors · 2025-12-05T20:22:21Z

💔 Test failed - checks-actions

devnexen · 2025-12-05T20:25:32Z

oh I see, the freebsd ABI had not been updated, so yes no chance to work as is.

Enselic · 2025-12-05T22:04:41Z

Ok, let's marked as S-blocked for now. Just ping when this can be tried again.

jhpratt · 2026-01-04T21:42:24Z

@bors r- (sync)

rustbot assigned m-ou-se Feb 2, 2024

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 2, 2024

This comment has been minimized.

Sign in to view

devnexen force-pushed the cpuaff_fbsd_upd branch from c7ea25b to 8e12778 Compare February 2, 2024 22:20

the8472 reviewed Feb 2, 2024

View reviewed changes

library/std/src/sys/pal/unix/thread.rs Outdated Show resolved Hide resolved

devnexen force-pushed the cpuaff_fbsd_upd branch from 8e12778 to 0bfcafd Compare February 3, 2024 00:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024

matthiaskrgr mentioned this pull request Feb 8, 2024

Rollup of 9 pull requests #120794

Closed

matthiaskrgr mentioned this pull request Feb 8, 2024

Rollup of 10 pull requests #120795

Closed

matthiaskrgr mentioned this pull request Feb 8, 2024

Rollup of 9 pull requests #120799

Closed

matthiaskrgr mentioned this pull request Feb 8, 2024

Rollup of 10 pull requests #120800

Closed

matthiaskrgr mentioned this pull request Feb 9, 2024

Rollup of 9 pull requests #120824

Closed

matthiaskrgr mentioned this pull request Feb 9, 2024

Rollup of 7 pull requests #120861

Closed

rustbot added the T-clippy Relevant to the Clippy team. label Dec 2, 2025

devnexen force-pushed the cpuaff_fbsd_upd branch from c4a03dd to d10f274 Compare December 2, 2025 06:18

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2025

std::thread::available_parallelism merging linux/android/freebsd version

3ccabb4

FreeBSD 13.1 had introduced a sched cpu affinity compatibility layer with Linux. 13.0 and even 13.1 being EOL, we can simplify here. a

devnexen force-pushed the cpuaff_fbsd_upd branch from d10f274 to 3ccabb4 Compare December 2, 2025 07:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2025

Enselic added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 4, 2026

Enselic added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. labels Jan 5, 2026

Uh oh!

Conversation

devnexen commented Feb 2, 2024

Uh oh!

rustbot commented Feb 2, 2024

Uh oh!

This comment has been minimized.

Uh oh!

m-ou-se commented Feb 8, 2024

Uh oh!

bors commented Feb 8, 2024

Uh oh!

Nadrieril commented Feb 8, 2024

Uh oh!

matthiaskrgr commented Feb 9, 2024

Uh oh!

rustbot commented Dec 2, 2025

Uh oh!

devnexen commented Dec 2, 2025

Uh oh!

blyxyas commented Dec 2, 2025

Uh oh!

Enselic commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Dec 5, 2025

Uh oh!

devnexen commented Dec 5, 2025

Uh oh!

bors commented Dec 5, 2025

Uh oh!

rust-log-analyzer commented Dec 5, 2025

Uh oh!

bors commented Dec 5, 2025

Uh oh!

devnexen commented Dec 5, 2025

Uh oh!

Enselic commented Dec 5, 2025

Uh oh!

jhpratt commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Enselic commented Dec 5, 2025 •

edited

Loading