Skip to content

Add more checks for unnamed_fields during HIR analysis#121198

Merged
bors merged 1 commit intorust-lang:masterfrom
clubby789:unnamed-fields-hir-checks
Feb 18, 2024
Merged

Add more checks for unnamed_fields during HIR analysis#121198
bors merged 1 commit intorust-lang:masterfrom
clubby789:unnamed-fields-hir-checks

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Feb 16, 2024 •
edited
Loading

Fixes #121151

I also found that we don't prevent enums here so

#[repr(C)]
#[derive(Debug)]
enum A {
    #[default]
    B,
    C,
}

#[repr(C)]
#[derive(Debug)]
struct D {
    _: A,
}

leads to an ICE on an self.is_struct() || self.is_union() assertion, so fixed that too.

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2024
@clubby789 clubby789 added the F-unnamed_fields `#![feature(unnamed_fields)]` label Feb 16, 2024
@clubby789 clubby789 changed the title Add more checks for unnamed_field during HIR analysis Add more checks for unnamed_fields during HIR analysis Feb 16, 2024
compiler-errors
compiler-errors approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! thanks

@compiler-errors
Copy link
Contributor

compiler-errors commented Feb 16, 2024

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

📌 Commit c370403 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned estebank Feb 16, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#121198 - clubby789:unnamed-fields-hir-check…
f4f2a75 
…s, r=compiler-errors

Add more checks for `unnamed_fields` during HIR analysis

Fixes rust-lang#121151

I also found that we don't prevent enums here so
```rs
#[repr(C)]
#[derive(Debug)]
enum A {
    #[default]
    B,
    C,
}

#[repr(C)]
#[derive(Debug)]
struct D {
    _: A,
}
```
leads to an ICE on an `self.is_struct() || self.is_union()` assertion, so fixed that too.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 17, 2024
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Feb 17, 2024

@bors r-
#121234 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2024
@rust-cloud-vms rust-cloud-vms bot force-pushed the unnamed-fields-hir-checks branch from c370403 to 62b789f Compare February 17, 2024 15:12
@clubby789
Copy link
Contributor Author

clubby789 commented Feb 17, 2024

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Feb 17, 2024

📌 Commit 62b789f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 17, 2024
@GuillaumeGomez
Rollup merge of rust-lang#121198 - clubby789:unnamed-fields-hir-check…
f7e435b 
…s, r=compiler-errors

Add more checks for `unnamed_fields` during HIR analysis

Fixes rust-lang#121151

I also found that we don't prevent enums here so
```rs
#[repr(C)]
#[derive(Debug)]
enum A {
    #[default]
    B,
    C,
}

#[repr(C)]
#[derive(Debug)]
struct D {
    _: A,
}
```
leads to an ICE on an `self.is_struct() || self.is_union()` assertion, so fixed that too.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2024
@bors
Auto merge of rust-lang#121244 - GuillaumeGomez:rollup-995gu7o, r=Gui…
0da05e9 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118264 (Optimize `VecDeque::drain` for (half-)open ranges)
 - rust-lang#121079 (distribute tool documentations and avoid file conflicts on `x install`)
 - rust-lang#121100 (Detect when method call on argument could be removed to fulfill failed trait bound)
 - rust-lang#121160 (rustdoc: fix and refactor HTML rendering a bit)
 - rust-lang#121198 (Add more checks for `unnamed_fields` during HIR analysis)
 - rust-lang#121221 (AstConv: Refactor lowering of associated item bindings a bit)
 - rust-lang#121237 (Use better heuristic for printing Cargo specific diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Feb 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
@bors
Auto merge of rust-lang#121252 - fmease:rollup-x7zogl8, r=fmease
23a3d77 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#120526 (rustdoc: Correctly handle long crate names on mobile)
 - rust-lang#121100 (Detect when method call on argument could be removed to fulfill failed trait bound)
 - rust-lang#121160 (rustdoc: fix and refactor HTML rendering a bit)
 - rust-lang#121198 (Add more checks for `unnamed_fields` during HIR analysis)
 - rust-lang#121218 (Fix missing trait impls for type in rustc docs)
 - rust-lang#121221 (AstConv: Refactor lowering of associated item bindings a bit)
 - rust-lang#121237 (Use better heuristic for printing Cargo specific diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 68cf537 into rust-lang:master Feb 18, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
@rust-timer
Unrolled build for rust-lang#121198
ededfc3 
Rollup merge of rust-lang#121198 - clubby789:unnamed-fields-hir-checks, r=compiler-errors

Add more checks for `unnamed_fields` during HIR analysis

Fixes rust-lang#121151

I also found that we don't prevent enums here so
```rs
#[repr(C)]
#[derive(Debug)]
enum A {
    #[default]
    B,
    C,
}

#[repr(C)]
#[derive(Debug)]
struct D {
    _: A,
}
```
leads to an ICE on an `self.is_struct() || self.is_union()` assertion, so fixed that too.
@fmease fmease mentioned this pull request Feb 18, 2024
Open
4 tasks
@clubby789 clubby789 mentioned this pull request Feb 19, 2024
Closed
@clubby789 clubby789 linked an issue Feb 19, 2024 that may be closed by this pull request
ice: attempted .def_id() on invalid res: Err #120992
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

F-unnamed_fields `#![feature(unnamed_fields)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

ICE: is not an ADT ice: attempted .def_id() on invalid res: Err

6 participants

@clubby789 @rustbot @compiler-errors @bors @matthiaskrgr @estebank