Always emit `native-static-libs` note, even if it is empty by madsmtm · Pull Request #121216 · rust-lang/rust

madsmtm · 2024-02-17T03:45:58Z

try-job: x86_64-msvc

rustbot · 2024-02-17T03:46:05Z

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

madsmtm · 2024-02-17T06:45:59Z

Hmm, I have no idea why the test I added is failing, it does work if I run ./x test tests/ui/codegen/issue-108825.rs locally?

madsmtm · 2024-05-20T05:56:34Z

@rustbot ready

madsmtm · 2024-06-01T12:55:13Z

r? compiler

rustbot · 2024-06-01T12:55:15Z

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

lcnr · 2024-06-04T13:28:59Z

r? compiler

wesleywiser · 2024-06-13T14:35:44Z

Sorry @madsmtm for the long wait!

@bors r+ rollup

bors · 2024-06-13T14:35:47Z

📌 Commit 5cfe020 has been approved by wesleywiser

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#122613 (Don't build a broken/untested profiler runtime on mingw targets) - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126399 (extend the check for LLVM build) Failed merges: - rust-lang#126388 (const-eval: make lint scope computation consistent) r? `@ghost` `@rustbot` modify labels: rollup

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.) - rust-lang#126315 (Add pub struct with allow(dead_code) into worklist) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126399 (extend the check for LLVM build) r? `@ghost` `@rustbot` modify labels: rollup

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.) - rust-lang#126315 (Add pub struct with allow(dead_code) into worklist) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126399 (extend the check for LLVM build) - rust-lang#126436 (Reduce rustdoc GUI tests flakyness) r? `@ghost` `@rustbot` modify labels: rollup

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates) - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.) - rust-lang#126315 (Add pub struct with allow(dead_code) into worklist) - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns) - rust-lang#126343 (Remove some msys2 utils) - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.) - rust-lang#126399 (extend the check for LLVM build) r? `@ghost` `@rustbot` modify labels: rollup

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#121216 (Always emit `native-static-libs` note, even if it is empty) - rust-lang#123726 (Clarify `Command::new` behavior for programs with arguments) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126088 ([1/2] clean-up / general improvements) - rust-lang#126390 (Fix wording in {checked_}next_power_of_two) - rust-lang#126392 (Small style improvement in `gvn.rs`) - rust-lang#126402 (Fix wrong `assert_unsafe_precondition` message for `core::ptr::copy`) - rust-lang#126445 (Remove failing GUI test to stop blocking CI until it is fixed) r? `@ghost` `@rustbot` modify labels: rollup

workingjubilee · 2024-06-14T00:29:09Z

Failed in #126446 (comment)

diff of stderr:

1 note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
2 
- note: native-static-libs: 
+ note: native-static-libs: /defaultlib:msvcrt
5 


The actual stderr differed from the expected stderr.
The actual stderr differed from the expected stderr.
Actual stderr saved to C:\a\rust\rust\build\x86_64-pc-windows-msvc\test\ui\codegen\empty-static-libs-issue-108825\empty-static-libs-issue-108825.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args codegen\empty-static-libs-issue-108825.rs`

error: 1 errors occurred comparing output.
status: exit code: 0
command: PATH="C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\bin;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\HostX64\x64;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-bootstrap-tools\x86_64-pc-windows-msvc\release\deps;C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin;C:\Program Files\PowerShell\7;C:\a\_temp\msys64\mingw64\bin;C:\a\_temp\msys64\usr\local\bin;C:\a\_temp\msys64\usr\bin;C:\a\_temp\msys64\usr\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\sccache;C:\a\_temp\setup-msys2;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.15.7\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.0\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.10\x64\bin;C:\hostedtoolcache\windows\Python\3.9.13\x64\Scripts;C:\hostedtoolcache\windows\Python\3.9.13\x64;C:\hostedtoolcache\windows\Ruby\3.0.7\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\ProgramData\docker-compose;C:\ProgramData\Chocolatey\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\dotnet;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files\Microsoft SQL Server\150\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\WiX Toolset v3.14\bin;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps;C:\a\_temp\msys64\usr\bin\site_perl;C:\a\_temp\msys64\usr\bin\vendor_perl;C:\a\_temp\msys64\usr\bin\core_perl" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\bin\\rustc.exe" "C:\\a\\rust\\rust\\tests\\ui\\codegen\\empty-static-libs-issue-108825.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\Users\\runneradmin\\.cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=C:\\a\\rust\\rust\\vendor" "--sysroot" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2" "--target=x86_64-pc-windows-msvc" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui\\codegen\\empty-static-libs-issue-108825" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\native\\rust-test-helpers" "-L" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\test\\ui\\codegen\\empty-static-libs-issue-108825\\auxiliary" "-Cpanic=abort" "--print=native-static-libs"
--- stderr -------------------------------
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.


note: native-static-libs: /defaultlib:msvcrt



failures:
failures:
    [ui] tests\ui\codegen\empty-static-libs-issue-108825.rs

test result: FAILED. 16778 passed; 1 failed; 253 ignored; 0 measured; 2 filtered out; finished in 380.06s

Some tests failed in compiletest suite=ui mode=ui host=x86_64-pc-windows-msvc target=x86_64-pc-windows-msvc
Build completed unsuccessfully in 0:40:14

@bors r-

bors · 2024-07-20T11:40:05Z

☔ The latest upstream changes (presumably #127998) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC · 2024-08-07T15:16:17Z

@madsmtm any updates on the failure? thanks

alex-semenyuk · 2024-10-04T12:52:49Z

@madsmtm
Form wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.

madsmtm · 2025-03-26T13:25:17Z

Sorry for never responding here - I've filed a new PR in #138987.

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825. Retry of rust-lang#121216, finally got around to fixing the test, the errors in that PR were because `libcore` uses the `#[link]` attribute on MSVC. try-job: x86_64-msvc r? wesleywiser

Rollup merge of rust-lang#138987 - madsmtm:fix-108825, r=jieyouxu Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825. Retry of rust-lang#121216, finally got around to fixing the test, the errors in that PR were because `libcore` uses the `#[link]` attribute on MSVC. try-job: x86_64-msvc r? wesleywiser

rustbot assigned wesleywiser Feb 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 17, 2024

This comment has been minimized.

Sign in to view

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2024

madsmtm force-pushed the fix-108825 branch from 6bd996a to c4a7cb7 Compare May 20, 2024 02:57

This comment has been minimized.

Sign in to view

madsmtm force-pushed the fix-108825 branch from c4a7cb7 to fbef602 Compare May 20, 2024 03:08

This comment has been minimized.

Sign in to view

madsmtm marked this pull request as draft May 20, 2024 04:05

This comment has been minimized.

Sign in to view

Always emit native-static-libs note, even if it is empty

5cfe020

madsmtm force-pushed the fix-108825 branch from 0597225 to 5cfe020 Compare May 20, 2024 04:38

madsmtm marked this pull request as ready for review May 20, 2024 05:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2024

rustbot assigned lcnr and unassigned wesleywiser Jun 1, 2024

rustbot assigned TaKO8Ki and unassigned lcnr Jun 4, 2024

wesleywiser approved these changes Jun 13, 2024

View reviewed changes

matthiaskrgr mentioned this pull request Jun 13, 2024

Rollup of 7 pull requests #126412

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2024

Rollup merge of rust-lang#121216 - madsmtm:fix-108825, r=wesleywiser

a5709f3

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

matthiaskrgr mentioned this pull request Jun 13, 2024

Rollup of 8 pull requests #126433

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2024

Rollup merge of rust-lang#121216 - madsmtm:fix-108825, r=wesleywiser

7dd5ad7

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

matthiaskrgr mentioned this pull request Jun 13, 2024

Rollup of 9 pull requests #126438

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 13, 2024

Rollup merge of rust-lang#121216 - madsmtm:fix-108825, r=wesleywiser

4d79179

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

matthiaskrgr mentioned this pull request Jun 13, 2024

Rollup of 8 pull requests #126441

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 13, 2024

Rollup merge of rust-lang#121216 - madsmtm:fix-108825, r=wesleywiser

9958f1f

Always emit `native-static-libs` note, even if it is empty Fixes rust-lang#108825.

workingjubilee mentioned this pull request Jun 13, 2024

Rollup of 8 pull requests #126446

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2024

alex-semenyuk closed this Oct 4, 2024

madsmtm mentioned this pull request Mar 26, 2025

Always emit native-static-libs note, even if it is empty #138987

Merged

Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 30, 2025

Uh oh!

Conversation

madsmtm commented Feb 17, 2024 • edited by workingjubilee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 17, 2024

Uh oh!

This comment has been minimized.

madsmtm commented Feb 17, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

madsmtm commented May 20, 2024

Uh oh!

madsmtm commented Jun 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 1, 2024

Uh oh!

lcnr commented Jun 4, 2024

Uh oh!

wesleywiser commented Jun 13, 2024

Uh oh!

bors commented Jun 13, 2024

Uh oh!

workingjubilee commented Jun 14, 2024

Uh oh!

bors commented Jul 20, 2024

Uh oh!

Dylan-DPC commented Aug 7, 2024

Uh oh!

alex-semenyuk commented Oct 4, 2024

Uh oh!

madsmtm commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

madsmtm commented Feb 17, 2024 •

edited by workingjubilee

Loading

madsmtm commented Jun 1, 2024 •

edited

Loading