match lowering: Introduce a TestCase enum to replace most matching on PatKind#121393
Merged
bors merged 4 commits intorust-lang:masterfrom Feb 22, 2024
Merged
match lowering: Introduce a TestCase enum to replace most matching on PatKind#121393bors merged 4 commits intorust-lang:masterfrom
TestCase enum to replace most matching on PatKind#121393bors merged 4 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Nadrieril
force-pushed
the
match-lowering-testcase
branch
from
b9bdc77 to
0610f59
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#120598 (No need to `validate_alias_bound_self_from_param_env` in `assemble_alias_bound_candidates`) - rust-lang#121386 (test that we do not support higher-ranked regions in opaque type inference) - rust-lang#121393 (match lowering: Introduce a `TestCase` enum to replace most matching on `PatKind`) - rust-lang#121401 (Fix typo in serialized.rs) - rust-lang#121427 (Fix panic when compiling `Rocket`.) - rust-lang#121439 (Fix typo in metadata.rs doc comment) - rust-lang#121441 (`DefId` to `LocalDefId`) - rust-lang#121452 (Add new maintainers to nto-qnx.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2024
Rollup merge of rust-lang#121393 - Nadrieril:match-lowering-testcase, r=matthewjasper match lowering: Introduce a `TestCase` enum to replace most matching on `PatKind` Introduces `TestCase` that represents the specific outcome of a test. It complements `TestKind` which represents a test. In `MatchPair::new()` we select the appropriate `TestCase` for the pattern, and after that we almost never have to inspect the pattern directly during match lowering. Together with rust-lang#120904, this makes `MatchPair` into a standalone abstraction that hides the details of `thir::Pat`. This will become even truer in the next PR where I make `TestCase` handle or patterns. This opens the door to a lot of future simplifications. r? `@matthewjasper`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
TestCasethat represents the specific outcome of a test. It complementsTestKindwhich represents a test. InMatchPair::new()we select the appropriateTestCasefor the pattern, and after that we almost never have to inspect the pattern directly during match lowering.Together with #120904, this makes
MatchPairinto a standalone abstraction that hides the details ofthir::Pat. This will become even truer in the next PR where I makeTestCasehandle or patterns. This opens the door to a lot of future simplifications.r? @matthewjasper