Make QNX/NTO specific "timespec capping" public to crate::sys#121498
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 23, 2024
Merged
Make QNX/NTO specific "timespec capping" public to crate::sys#121498bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
It is used in: - `library/std/src/sys/locks/condvar/pthread.rs` - `library/std/src/sys/pal/unix/thread_parking/pthread.rs`
Collaborator
rustbot
added
O-unix
Noratrieb
approved these changes
Feb 23, 2024
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
Is this a draft by accident? Or have you not tested it?
Contributor
Author
|
I have tested it and I think it can be merged but wanted to give @jonathanpallant and @japaric the chance to have a look at it as well 😃 . |
Contributor
Author
|
Sorry for not making this clear from the beginning |
Contributor
|
Can confirm this patch allows the qnx std target to build again, and I used it to successfully create a QNX binary. |
Contributor
Author
|
@Nilstrieb please r+ |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#120742 (mark `min_exhaustive_patterns` as complete) - rust-lang#121470 (Don't ICE on anonymous struct in enum variant) - rust-lang#121492 (coverage: Rename `is_closure` to `is_hole`) - rust-lang#121495 (remove repetitive words) - rust-lang#121498 (Make QNX/NTO specific "timespec capping" public to crate::sys) - rust-lang#121510 (lint-overflowing-ops: unify cases and remove redundancy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2024
Rollup merge of rust-lang#121498 - flba-eb:make_timespec_capping_public, r=Nilstrieb Make QNX/NTO specific "timespec capping" public to crate::sys It is used in: - `library/std/src/sys/locks/condvar/pthread.rs` - `library/std/src/sys/pal/unix/thread_parking/pthread.rs` This is probably required due to introduction of `sys/pal` and rust-lang#121177 `@rustbot` label +O-neutrino CC: `@jonathanpallant` `@japaric` `@gh-tr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is used in:
library/std/src/sys/locks/condvar/pthread.rslibrary/std/src/sys/pal/unix/thread_parking/pthread.rsThis is probably required due to introduction of
sys/paland #121177@rustbot label +O-neutrino
CC: @jonathanpallant @japaric @gh-tr