Stop using Bubble in coherence and instead emulate it with an intercrate check by oli-obk · Pull Request #121744 · rust-lang/rust

oli-obk · 2024-02-28T16:04:50Z

This change is kinda funny, because all I've done is reimplement Bubble behaviour for coherence without using Bubble explicitly.

compiler-errors · 2024-02-28T16:13:51Z

compiler/rustc_infer/src/infer/opaque_types.rs

                    DefiningAnchor::Bubble => {}
-                    DefiningAnchor::Error => return None,
+                    DefiningAnchor::Error => {
+                        if !self.intercrate {


Aren't we sometimes emitting alias-relate goals in coherence? Or we planned to do so? Perhaps we could just do that and assert against self.intercrate in this function.

We're def not doing that right now. I presumed we didn't want to touch old coherence anymore and just wait until it gets replaced by the new solver, which doesn't care about the bubble/error distinction anyway.

can you change it to match on DefiningAnchor only if intercrate is false instead? Only having the intercrate check in the Error branch feels weird 🤔

compiler-errors · 2024-02-28T16:47:12Z

prefer if lcnr reviews this

r? lcnr

lcnr · 2024-03-01T10:10:27Z

@bors r+ rollup

bors · 2024-03-01T10:10:31Z

📌 Commit 836ac98 has been approved by lcnr

It is now in the queue for this repository.

Stop using Bubble in coherence and instead emulate it with an intercrte check r? `@compiler-errors` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

Stop using Bubble in coherence and instead emulate it with an intercrte check r? ``@compiler-errors`` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#119199 (Add arm64ec-pc-windows-msvc target) - rust-lang#121416 (Improve error messages for generics with default parameters) - rust-lang#121475 (Add tidy check for .stderr/.stdout files for non-existent test revisions) - rust-lang#121736 (Remove `Mutex::unlock` Function) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrte check) - rust-lang#121784 (Make the success arms of `if lhs || rhs` meet up in a separate block) - rust-lang#121818 (CFI: Remove unused `typeid_for_fnsig`) - rust-lang#121819 (Handle stashing of delayed bugs) - rust-lang#121828 (Remove unused fluent messages) - rust-lang#121831 (Fix typo in comment) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-03-01T16:24:03Z

@bors r-
#121845 (comment)

…ate check

oli-obk · 2024-03-05T05:52:59Z

@bors r=lcnr

bors · 2024-03-05T05:53:01Z

📌 Commit c98be32 has been approved by lcnr

It is now in the queue for this repository.

Stop using Bubble in coherence and instead emulate it with an intercrate check r? `@compiler-errors` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

Stop using Bubble in coherence and instead emulate it with an intercrate check r? ``@compiler-errors`` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

Stop using Bubble in coherence and instead emulate it with an intercrate check r? ```@compiler-errors``` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121301 (errors: share `SilentEmitter` between rustc and rustfmt) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#121905 (Add a `description` field to target definitions) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup

Stop using Bubble in coherence and instead emulate it with an intercrate check r? ````@compiler-errors```` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121832 (Add new Tier-3 target: `loongarch64-unknown-linux-musl`) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#122014 (Change some attributes to only_local.) - rust-lang#122016 (will_wake tests fail on Miri and that is expected) - rust-lang#122018 (only set noalias on Box with the global allocator) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121065 (Add basic i18n guidance for `Display`) - rust-lang#121744 (Stop using Bubble in coherence and instead emulate it with an intercrate check) - rust-lang#121829 (Dummy tweaks (attempt 2)) - rust-lang#121857 (Implement async closure signature deduction) - rust-lang#121894 (const_eval_select: make it safe but be careful with what we expose on stable for now) - rust-lang#122014 (Change some attributes to only_local.) - rust-lang#122016 (will_wake tests fail on Miri and that is expected) - rust-lang#122018 (only set noalias on Box with the global allocator) - rust-lang#122028 (Remove some dead code) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121744 - oli-obk:eager_opaque_checks2, r=lcnr Stop using Bubble in coherence and instead emulate it with an intercrate check r? `````@compiler-errors````` This change is kinda funny, because all I've done is reimplement `Bubble` behaviour for coherence without using `Bubble` explicitly.

rustbot assigned compiler-errors Feb 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2024

compiler-errors reviewed Feb 28, 2024

View reviewed changes

rustbot assigned lcnr and unassigned compiler-errors Feb 28, 2024

oli-obk force-pushed the eager_opaque_checks2 branch from d5f39d3 to 836ac98 Compare March 1, 2024 10:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 11 pull requests #121844

Closed

matthiaskrgr mentioned this pull request Mar 1, 2024

Rollup of 10 pull requests #121845

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2024

oli-obk changed the title ~~Stop using Bubble in coherence and instead emulate it with an intercrte check~~ Stop using Bubble in coherence and instead emulate it with an intercrate check Mar 5, 2024

Stop using Bubble in coherence and instead emulate it with an intercr…

c98be32

…ate check

oli-obk force-pushed the eager_opaque_checks2 branch from 836ac98 to c98be32 Compare March 5, 2024 05:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2024

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 10 pull requests #122030

Closed

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 9 pull requests #122032

Closed

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 9 pull requests #122033

Closed

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 10 pull requests #122039

Closed

matthiaskrgr mentioned this pull request Mar 5, 2024

Rollup of 9 pull requests #122045

Merged

bors merged commit e2e8405 into rust-lang:master Mar 6, 2024

rustbot added this to the 1.78.0 milestone Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stop using Bubble in coherence and instead emulate it with an intercrate check#121744

Stop using Bubble in coherence and instead emulate it with an intercrate check#121744
bors merged 1 commit intorust-lang:masterfrom
oli-obk:eager_opaque_checks2

oli-obk commented Feb 28, 2024

Uh oh!

compiler-errors Feb 28, 2024

Uh oh!

oli-obk Feb 28, 2024

Uh oh!

lcnr Feb 29, 2024

Uh oh!

compiler-errors commented Feb 28, 2024

Uh oh!

lcnr commented Mar 1, 2024

Uh oh!

bors commented Mar 1, 2024

Uh oh!

matthiaskrgr commented Mar 1, 2024

Uh oh!

oli-obk commented Mar 5, 2024

Uh oh!

bors commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

oli-obk commented Feb 28, 2024

Uh oh!

compiler-errors Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

oli-obk Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

lcnr Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Feb 28, 2024

Uh oh!

lcnr commented Mar 1, 2024

Uh oh!

bors commented Mar 1, 2024

Uh oh!

matthiaskrgr commented Mar 1, 2024

Uh oh!

oli-obk commented Mar 5, 2024

Uh oh!

bors commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants