Fix redundant import errors for preload extern crate by chenyukang · Pull Request #121958 · rust-lang/rust

chenyukang · 2024-03-04T02:36:48Z

Fixes #121915

rustbot · 2024-03-04T02:36:55Z

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

pnkfelix · 2024-03-04T15:12:44Z

@bors r+

bors · 2024-03-04T15:12:49Z

📌 Commit 25e56de has been approved by pnkfelix

It is now in the queue for this repository.

pnkfelix · 2024-03-04T15:12:53Z

@bors rollup

…t, r=pnkfelix Fix redundant import errors for preload extern crate Fixes rust-lang#121915

compiler/rustc_lint/src/context/diagnostics.rs

compiler/rustc_resolve/src/imports.rs

compiler/rustc_lint/src/context/diagnostics.rs

tests/ui/imports/redundant-import-issue-121915.rs

petrochenkov · 2024-03-04T16:04:37Z

r? @petrochenkov
@bors r-

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#120976 (constify a couple thread_local statics) - rust-lang#121576 (Convert the rest of the visitors to use `VisitorResult`) - rust-lang#121826 (Use root obligation on E0277 for some cases) - rust-lang#121928 (Extract an arguments struct for `Builder::then_else_break`) - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#121968 (Don't run test_get_os_named_thread on win7) - rust-lang#121977 (Doc: Fix incorrect reference to integer in Atomic{Ptr,Bool}::as_ptr.) - rust-lang#121978 (Fix duplicated path in the "not found dylib" error) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2024-03-04T18:38:42Z

I've closed the rollup PR, #121982, which included this PR. petrochenkov, in the future could you please immediately r- any corresponding rollup PRs to prevent us merging outdated/r-'ed commits. Thanks!

chenyukang · 2024-03-05T14:07:45Z

@petrochenkov @surechen
I updated the code and tests.

compiler/rustc_resolve/src/imports.rs

tests/ui/imports/suggest-remove-issue-121315.rs

petrochenkov · 2024-03-06T11:22:58Z

I suggest landing all the changes except removal spans in a separate PR.

chenyukang · 2024-03-06T13:25:53Z

I suggest landing all the changes except removal spans in a separate PR.

Rollbacked to only fix #121915 now, will send another PR for #121315.

petrochenkov · 2024-03-06T14:02:32Z

I see you kept the added tests, that's great.
@bors r+

bors · 2024-03-06T14:02:35Z

📌 Commit 5a4ff27 has been approved by petrochenkov

It is now in the queue for this repository.

…t, r=petrochenkov Fix redundant import errors for preload extern crate Fixes rust-lang#121915

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122066 (Add proper cfgs for struct HirIdValidator used only with debug-assert) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121958 - chenyukang:yukang-fix-121915-import, r=petrochenkov Fix redundant import errors for preload extern crate Fixes rust-lang#121915

rustbot assigned pnkfelix Mar 4, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2024

chenyukang force-pushed the yukang-fix-121915-import branch from 6985c4b to 25e56de Compare March 4, 2024 02:38

petrochenkov self-assigned this Mar 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 4, 2024

Rollup merge of rust-lang#121958 - chenyukang:yukang-fix-121915-impor…

85f3738

…t, r=pnkfelix Fix redundant import errors for preload extern crate Fixes rust-lang#121915

GuillaumeGomez mentioned this pull request Mar 4, 2024

Rollup of 9 pull requests #121982

Closed

petrochenkov reviewed Mar 4, 2024

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2024

petrochenkov unassigned pnkfelix Mar 4, 2024

This comment was marked as resolved.

Sign in to view

chenyukang force-pushed the yukang-fix-121915-import branch 2 times, most recently from 23f52db to f6aa902 Compare March 5, 2024 13:59

petrochenkov reviewed Mar 5, 2024

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

chenyukang force-pushed the yukang-fix-121915-import branch 2 times, most recently from 74ed601 to 4e5c823 Compare March 6, 2024 03:47

chenyukang commented Mar 6, 2024

View reviewed changes

tests/ui/imports/suggest-remove-issue-121315.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-fix-121915-import branch from 4e5c823 to a2c624b Compare March 6, 2024 04:12

chenyukang force-pushed the yukang-fix-121915-import branch from a2c624b to ac035e7 Compare March 6, 2024 04:18

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-fix-121915-import branch 4 times, most recently from 741df34 to ea4a7bf Compare March 6, 2024 13:23

chenyukang force-pushed the yukang-fix-121915-import branch from ea4a7bf to b0618b8 Compare March 6, 2024 13:27

Fix redundant import errors for preload extern crate

5a4ff27

chenyukang force-pushed the yukang-fix-121915-import branch from b0618b8 to 5a4ff27 Compare March 6, 2024 13:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2024

Rollup merge of rust-lang#121958 - chenyukang:yukang-fix-121915-impor…

8f99d57

…t, r=petrochenkov Fix redundant import errors for preload extern crate Fixes rust-lang#121915

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 10 pull requests #122096

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 9 pull requests #122113

Merged

bors merged commit 550b8a2 into rust-lang:master Mar 7, 2024

rustbot added this to the 1.78.0 milestone Mar 7, 2024

Uh oh!

Conversation

chenyukang commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 4, 2024

Uh oh!

pnkfelix commented Mar 4, 2024

Uh oh!

bors commented Mar 4, 2024

Uh oh!

pnkfelix commented Mar 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Mar 4, 2024

Uh oh!

fmease commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

chenyukang commented Mar 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Mar 6, 2024

Uh oh!

chenyukang commented Mar 6, 2024

Uh oh!

petrochenkov commented Mar 6, 2024

Uh oh!

bors commented Mar 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chenyukang commented Mar 4, 2024 •

edited

Loading

fmease commented Mar 4, 2024 •

edited

Loading