Use hir::Node helper methods instead of repeating the same impl multiple times#122021
Use hir::Node helper methods instead of repeating the same impl multiple times#122021bors merged 2 commits intorust-lang:masterfrom
Conversation
|
rustbot has assigned @compiler-errors. Use r? to explicitly pick a reviewer |
oli-obk
changed the title
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
delangitemification
branch
from
5f24dd3 to
6baf7fd
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
☔ The latest upstream changes (presumably #122511) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Sorry for taking so long on this, r=me after rebase
compiler-errors
added
S-waiting-on-author
They match on almost the same patterns, which is fishy. Also turn `associated_body` into a method and do some cleanups nearby the call sites
…le times There already were inconsistencies, so this ensures we don't introduce subtle surprising bugs
oli-obk
force-pushed
the
delangitemification
branch
from
6baf7fd to
69c4e81
Compare
|
Some changes occurred in coverage instrumentation. cc @Zalathar |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
…piler-errors Use hir::Node helper methods instead of repeating the same impl multiple times I wanted to do something entirely different and stumbled upon a bunch of cleanups
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f296c16): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.396s -> 669.996s (0.09%) |
…ler-errors Use hir::Node helper methods instead of repeating the same impl multiple times I wanted to do something entirely different and stumbled upon a bunch of cleanups
6 participants
I wanted to do something entirely different and stumbled upon a bunch of cleanups