Don't let rustdoc source code urls look at bodies#122133
Closed
oli-obk wants to merge 1 commit intorust-lang:masterfrom
Closed
Don't let rustdoc source code urls look at bodies#122133oli-obk wants to merge 1 commit intorust-lang:masterfrom
oli-obk wants to merge 1 commit intorust-lang:masterfrom
Conversation
It is too fragile (keeps ICEing) and will only ever work for a single cfg, but rustdoc looks at all cfgs at the same time
Member
|
That saddens me a lot but not much can be done I suppose... Can you add test which currently fails so that we can avoid bringing in new breaking changes in the future please? |
Contributor
Author
|
we discussed this in DMs. #122066 (comment) will disable it for rustc, and there are current plans for major changes about it on the rustdoc side |
Member
|
For everyone to know: the plan is to remove all this from rustdoc and instead re-use the existing in JS so that such issues don't occur ever again (so no more compiler queries). |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is too fragile (keeps ICEing) and will only ever work for a single cfg, but rustdoc looks at all cfgs at the same time
see also #122066 (comment) and #69426 (comment)
r? @GuillaumeGomez