[WIP] [crater-only] Make a watered-down version of lazy type aliases the default#122308
Closed
fmease wants to merge 1 commit intorust-lang:masterfrom
Closed
[WIP] [crater-only] Make a watered-down version of lazy type aliases the default#122308fmease wants to merge 1 commit intorust-lang:masterfrom
fmease wants to merge 1 commit intorust-lang:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #122341) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
I've got a better idea. It'll take a bit of time to impl but I predict it'll be a lot more fruitful and actionable. Namely, instead of trying to crater-run "LTA_watered_down", the better approach would be to "auto-migrate" the crates under test to LTA and to enable proper/full LTA by default. This approach is blocked on impl'ing the migration lint (which has been on my TODO list for a while now anyway) + some smaller details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for crater yet since this patch can't build stage1 std at the moment 🥲, still need to figure that out.
I've at least managed to make it build stage1 core & alloc.