Recurse into args in WF even if they have escaping bound vars#122501
Recurse into args in WF even if they have escaping bound vars#122501compiler-errors wants to merge 2 commits intorust-lang:masterfrom
Conversation
|
@bors try |
Recurse into args in WF even if they have escaping bound vars Might have some subtle breakage but it's afaict always more correct to do this. r? `@ghost`
|
TODO: And a similar test for projections. |
|
can you maybe crater this change together with a different PR 🤔 there are currently 5 PRs in the crater queue and I expect this change to have 1) pretty clear error messages and 2) probably no failures. Maybe as an additional commit in #122317? A crater-rollup :3 |
Crater rollup This is a crater rollup of: - [ ] rust-lang#122317 - [ ] rust-lang#122501 - [ ] rust-lang#122077 What does that mean? Well, I'm gonna run crater with p=3 on this PR, and then re-run *just* the list of failed crates on each PR. That should deduplicate the bulk of crates which we expect are unaffected by these PRs. Don't touch this PR please. r? `@ghost`
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Crater rollup This is a crater rollup of: - [ ] rust-lang#122317 - [ ] rust-lang#122501 - [ ] rust-lang#122077 What does that mean? Well, I'm gonna run crater with p=3 on this PR, and then re-run *just* the list of failed crates on each PR. That should deduplicate the bulk of crates which we expect are unaffected by these PRs. Don't touch this PR please. r? `@ghost`
This comment has been minimized.
This comment has been minimized.
5fed9f0 to
cb50cae
Compare
|
@bors try |
Recurse into args in WF even if they have escaping bound vars Might have some subtle breakage but it's afaict always more correct to do this. r? `@ghost`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
gdi |
|
i think this is way too much breakage and i have no idea how to proceed so im just gonna close this :( wish there was a graveyard for things like this so future types ppl could see "what happens if we start actually checking wf on things" lol |
Might have some subtle breakage but it's afaict always more correct to do this.
r? @ghost