Build core, alloc, std with 1 CGU#122522
Closed
erikdesjardins wants to merge 1 commit intorust-lang:masterfrom
Closed
Build core, alloc, std with 1 CGU#122522erikdesjardins wants to merge 1 commit intorust-lang:masterfrom
erikdesjardins wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
Member
|
Did you run your benchmark on a local build with the rust.codegen-units-std=1 config? This should be the setting we currently use to build the std on the main targets. rust.codegen-units=1 is indeed set on CI so that local builds are not slowed down too much. IIRC #115554 didn’t have binary size improvements because we were already building the std with 1 CGU. |
Contributor
Author
|
Ah, that's what I was missing. Yeah, this has no effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally, this makes helloworld ~24% smaller:
It also makes
./x build --stage 1~10% slower after a change to the stdlib (2:45 -> 3:00).I'm not sure if that tradeoff is worthwhile.
Let's do a perf run first.
r? @ghost