Split hir ty lowerer's error reporting code in check functions to mod errors.#122865
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 3, 2024
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #120926) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
astconv is kill |
rustbot
added
S-waiting-on-author
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
83cafab to
fcb3dcb
Compare
Collaborator
|
HIR ty lowering was modified cc @fmease |
fmease
changed the title
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
fcb3dcb to
f9a328f
Compare
Contributor
Author
Thank you for your reminder @workingjubilee |
Contributor
Author
Contributor
Author
Thank you very much.If CI does not complain, please help me continue to review. I tested it locally and I think there should be no tests error. |
rustbot
added
S-waiting-on-review
lcnr
reviewed
Mar 24, 2024
compiler/rustc_hir_analysis/src/hir_ty_lowering/object_safety.rs
Outdated
Show resolved
Hide resolved
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
f9a328f to
7940303
Compare
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
7940303 to
71fd305
Compare
lcnr
reviewed
Apr 2, 2024
Comment on lines
1279
to
1280
| pub struct EnumVariantsGenericsErrExtend<'tcx> { | ||
| pub tcx: TyCtxt<'tcx>, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
71fd305 to
0f57ff8
Compare
This comment has been minimized.
This comment has been minimized.
Move some error report codes to mod `astconv/errors.rs`
surechen
force-pushed
the
refactor_astconv_error_report_20240321
branch
from
0f57ff8 to
1012218
Compare
Contributor
|
thanks ❤️ @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#122865 (Split hir ty lowerer's error reporting code in check functions to mod errors.) - rust-lang#122935 (rename ptr::from_exposed_addr -> ptr::with_exposed_provenance) - rust-lang#123182 (Avoid expanding to unstable internal method) - rust-lang#123203 (Add `Context::ext`) - rust-lang#123380 (Improve bootstrap comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2024
Rollup merge of rust-lang#122865 - surechen:refactor_astconv_error_report_20240321, r=lcnr Split hir ty lowerer's error reporting code in check functions to mod errors. Move some error report codes to mod `astconv/errors.rs` r? `@lcnr`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some error report codes to mod
astconv/errors.rsr? @lcnr