CFI: Fix methods as function pointer cast

[rcvalle]

Fix casting between methods and function pointers by assigning a secondary type id to methods with their concrete self so they can be used as function pointers.

This was split off from #116404.

cc @compiler-errors @workingjubilee

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in compiler/rustc_symbol_mangling/src/typeid

cc @rust-lang/project-exploit-mitigations, @rcvalle

[rcvalle]

r? @compiler-errors

[bors]

☔ The latest upstream changes (presumably #123065) made this pull request unmergeable. Please resolve the merge conflicts.

[maurer]

Overall LGTM. I would like to reduce the alias set and avoid using dyn Drop which already has a meaning distinct from what we're using here (maybe dyn Destruct?), but that can be done in a future PR, doesn't need to be this one.

[maurer]

Overall LGTM

[rcvalle]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[compiler-errors]

@bors r+

[bors]

📌 Commit 8e6b4e9 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8e6b4e9 with merge 30e054f...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

-- Configuring done (29.8s)
-- Generating done (2.6s)
-- Build files have been written to: C:/a/rust/rust/build/x86_64-pc-windows-msvc/llvm/build
running: "cmake" "--build" "." "--target" "install" "--config" "Release" "--" "-j" "8"
ninja: error: build.ninja:3780: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
thread 'main' panicked at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cmake-0.1.48\src\lib.rs:975:5:

command did not execute successfully, got: exit code: 1

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit 8e6b4e9 with merge 58dcd1f...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 58dcd1f to master...

[rust-timer]

Finished benchmarking commit (58dcd1f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.406s -> 668.769s (0.05%)
Artifact size: 315.93 MiB -> 315.81 MiB (-0.04%)