Conversation
Reproduce the bug from <rust-lang#123282> that indicates this feature gate hits edition-dependent resolution paths. Resolution changed in edition 2018, so test that as well. (cherry picked from commit 9a7b176)
Fixes rust-lang#123282 Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com> (cherry picked from commit 5afe072)
(cherry picked from commit 022e42d)
408c0ea ("unix time module now return result") dropped the From impl for SystemTime, breaking the hurd and horizon builds. Fixes rust-lang#123032 (cherry picked from commit 7b4e507)
(cherry picked from commit 4ff8a9b)
(cherry picked from commit f2fd2d8)
Collaborator
|
rustbot
added
O-unix
Member
Author
|
@bors r+ rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2024
[beta] backports - Fix f16 and f128 feature gates in editions other than 2015 rust-lang#123307 / rust-lang#123445 - Update to LLVM 18.1.2 rust-lang#122772 - unix fs: Make hurd using explicit new rather than From rust-lang#123057 - Don't inherit codegen attrs from parent static rust-lang#123310 - Make sure to insert Sized bound first into clauses list rust-lang#123302 r? cuviper
Contributor
|
Running our CI on this results in compiler crashes: I'm confused. Why aren't these tests run in the upstream CI? |
Member
Author
|
@raoulstrackx those tests do run in the Not sure why bors didn't react to CI completion here -- let's have another go... @bors retry |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f16andf128feature gate regression #123445Sizedbound first into clauses list #123302r? cuviper