Check def id before calling match_projection_projections#123471
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 6, 2024
Merged
Check def id before calling match_projection_projections#123471bors merged 1 commit intorust-lang:masterfrom
match_projection_projections#123471bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
compiler-errors
added
the
beta-nominated
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Contributor
Author
|
@bors rollup=never |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (8d490e3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.691s -> 667.537s (-0.17%) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 6, 2024
…tions_invariant, r=compiler-errors Add a debug asserts call to match_projection_projections to ensure invariant Small nit as follow up of rust-lang#123471. r? `@compiler-errors` `@bors` rollup=always
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2024
Rollup merge of rust-lang#123559 - spastorino:match_projection_projections_invariant, r=compiler-errors Add a debug asserts call to match_projection_projections to ensure invariant Small nit as follow up of rust-lang#123471. r? `@compiler-errors` `@bors` rollup=always
Contributor
rustbot
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
[beta] backports - fix attribute validation on associated items in traits rust-lang#121545 - Only inspect user-written predicates for privacy concerns rust-lang#123377 - Check def id before calling `match_projection_projections` rust-lang#123471 - Restore `pred_known_to_hold_modulo_regions` rust-lang#123578 - Beta revert "Use OS thread name by default" rust-lang#123533 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
[beta] backports - fix attribute validation on associated items in traits rust-lang#121545 - Only inspect user-written predicates for privacy concerns rust-lang#123377 - Check def id before calling `match_projection_projections` rust-lang#123471 - Restore `pred_known_to_hold_modulo_regions` rust-lang#123578 - Beta revert "Use OS thread name by default" rust-lang#123533 r? cuviper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I "inlined"
assemble_candidates_from_predicatesintofor_each_item_boundin #120584, I forgot to copy over the check that actually made sure the def id of the candidate was equal to the def id of the obligation. This means that we normalize goal a bit too often even if it's not productive to do so.This PR adds that def id check back.
Fixes #123448