std::thread: follow-up #123913 removing unsafe on success for glibc.#124095
Closed
devnexen wants to merge 1 commit intorust-lang:masterfrom
Closed
std::thread: follow-up #123913 removing unsafe on success for glibc.#124095devnexen wants to merge 1 commit intorust-lang:masterfrom
devnexen wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
Member
|
hm, this is needed for |
Member
Should they? That lint is denied in |
Member
That's a rollup. Which of the PRs in there do you mean? I don't think we should do this. Instead we should set |
Contributor
Author
|
I was not aware of this new lint, makes sense now. |
Member
|
Here's the issue for using this lint in std: #73904. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #123913