Use a proof tree visitor to refine the Obligation for error reporting in new solver#124418
Merged
bors merged 5 commits intorust-lang:masterfrom May 4, 2024
Merged
Use a proof tree visitor to refine the Obligation for error reporting in new solver#124418bors merged 5 commits intorust-lang:masterfrom
Obligation for error reporting in new solver#124418bors merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Collaborator
|
☔ The latest upstream changes (presumably #124527) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
better-cause
branch
from
919007b to
4246ba0
Compare
compiler-errors
commented
May 1, 2024
compiler-errors
commented
May 1, 2024
tests/ui/traits/next-solver/cycles/inductive-fixpoint-hang.stderr
Outdated
Show resolved
Hide resolved
compiler-errors
force-pushed
the
better-cause
branch
from
4246ba0 to
c0bbf6d
Compare
lcnr
reviewed
May 2, 2024
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
quite happy with this PR, reviewed this while in a room with errs and talked more about my review comments there :3
compiler-errors
force-pushed
the
better-cause
branch
from
c0bbf6d to
f6bfe28
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
better-cause
branch
from
f6bfe28 to
7d3cbcf
Compare
lcnr
reviewed
May 2, 2024
lcnr
reviewed
May 2, 2024
compiler-errors
force-pushed
the
better-cause
branch
from
7d3cbcf to
34e91ec
Compare
Contributor
Author
|
@bors r=lcnr |
Collaborator
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 4, 2024
Use a proof tree visitor to refine the `Obligation` for error reporting in new solver With the magic of `ProofTreeVisitor`, we can close the gap that we have on `ObligationCause`s being not as descriptive in the new trait solver. r? lcnr Needs some work and obviously documentation.
This was referenced May 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#124293 (Let miri and const eval execute intrinsics' fallback bodies) - rust-lang#124418 (Use a proof tree visitor to refine the `Obligation` for error reporting in new solver) - rust-lang#124480 (Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...`) - rust-lang#124648 (Trim crate graph) - rust-lang#124656 (release notes 1.78: add link to interior-mut breaking change) - rust-lang#124658 (Migrate `run-make/doctests-keep-binaries` to new rmake.rs format) - rust-lang#124681 (zkvm: fix run_tests) - rust-lang#124687 (Make `Bounds.clauses` private) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 4, 2024
Use a proof tree visitor to refine the `Obligation` for error reporting in new solver With the magic of `ProofTreeVisitor`, we can close the gap that we have on `ObligationCause`s being not as descriptive in the new trait solver. r? lcnr Needs some work and obviously documentation.
This was referenced May 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#124418 (Use a proof tree visitor to refine the `Obligation` for error reporting in new solver) - rust-lang#124480 (Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...`) - rust-lang#124648 (Trim crate graph) - rust-lang#124656 (release notes 1.78: add link to interior-mut breaking change) - rust-lang#124658 (Migrate `run-make/doctests-keep-binaries` to new rmake.rs format) - rust-lang#124678 (Stabilize `split_at_checked`) - rust-lang#124681 (zkvm: fix run_tests) - rust-lang#124687 (Make `Bounds.clauses` private) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 4, 2024
Rollup merge of rust-lang#124418 - compiler-errors:better-cause, r=lcnr Use a proof tree visitor to refine the `Obligation` for error reporting in new solver With the magic of `ProofTreeVisitor`, we can close the gap that we have on `ObligationCause`s being not as descriptive in the new trait solver. r? lcnr Needs some work and obviously documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the magic of
ProofTreeVisitor, we can close the gap that we have onObligationCauses being not as descriptive in the new trait solver.r? lcnr
Needs some work and obviously documentation.