Improve location reporting of trait placeholder error by compiler-errors · Pull Request #124977 · rust-lang/rust

compiler-errors · 2024-05-10T15:47:04Z

Self-explanatory

rustbot · 2024-05-10T15:47:13Z

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

fmease · 2024-05-10T17:45:52Z

compiler/rustc_borrowck/src/region_infer/mod.rs

                    // We currently do not store the `DefId` in the `ConstraintCategory`
                    // for performances reasons. The error reporting code used by NLL only
                    // uses the span, so this doesn't cause any problems at the moment.


Suggested change

// We currently do not store the `DefId` in the `ConstraintCategory`

// for performances reasons. The error reporting code used by NLL only

// uses the span, so this doesn't cause any problems at the moment.

or adjust accordingly?

cjgillot · 2024-05-10T18:24:20Z

tests/ui/coroutine/resume-arg-late-bound.stderr

  --> $DIR/resume-arg-late-bound.rs:15:5
   |
+LL | fn test(a: impl for<'a> Coroutine<&'a mut bool>) {}
+   |                 ------------------------------- due to a where-clause on `test`...


The terminology may be a bit surprising here.

compiler-errors · 2024-05-10T18:24:37Z

for performance purposes

@bors try @rust-timer queue

bors · 2024-05-10T18:25:47Z

⌛ Trying commit 70dcbe4 with merge ddbd46c...

…=<try> Improve location reporting of trait placeholder error Self-explanatory

bors · 2024-05-10T20:03:53Z

☀️ Try build successful - checks-actions
Build commit: ddbd46c (ddbd46cbd64e24ca82a50060455f3d7b74eb205e)

rust-timer · 2024-05-10T23:07:44Z

Finished benchmarking commit (ddbd46c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.9%	[-1.9%, -1.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-1.9%, -1.9%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.223s -> 674.916s (-0.19%)
Artifact size: 315.83 MiB -> 315.95 MiB (0.04%)

compiler-errors · 2024-07-16T15:59:11Z

@rustbot ready

bors · 2024-07-17T00:41:05Z

☔ The latest upstream changes (presumably #127831) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2024-07-19T22:31:08Z

compiler/rustc_borrowck/src/type_check/canonical.rs

        // Keep this parameter for now, in case we start using
        // it in `ConstraintCategory` at some point.


Suggested change

// Keep this parameter for now, in case we start using

// it in `ConstraintCategory` at some point.

cjgillot · 2024-07-19T22:33:30Z

compiler/rustc_infer/src/infer/error_reporting/nice_region_error/placeholder_error.rs

-        let (leading_ellipsis, satisfy_span, where_span, dup_span, def_id) =
-            if let ObligationCauseCode::WhereClause(def_id, span)
-            | ObligationCauseCode::WhereClauseInExpr(def_id, span, ..) = *cause.code()
-                && def_id != CRATE_DEF_ID.to_def_id()


Why is this check removed? process_registered_region_obligations still introduces a dummy crate def-id. Won't it cause issues?

compiler-errors · 2024-08-26T22:25:19Z

This is a nice improvement but I have no time for this anymore.

rustbot assigned cjgillot May 10, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2024

fmease reviewed May 10, 2024

View reviewed changes

cjgillot reviewed May 10, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request May 10, 2024

Auto merge of rust-lang#124977 - compiler-errors:higher-ranked-err, r…

ddbd46c

…=<try> Improve location reporting of trait placeholder error Self-explanatory

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2024

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024

Improve location reporting of trait placeholder error

59c2bc1

compiler-errors force-pushed the higher-ranked-err branch from 70dcbe4 to 59c2bc1 Compare July 10, 2024 20:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2024

cjgillot reviewed Jul 19, 2024

View reviewed changes

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024

compiler-errors closed this Aug 26, 2024

	// We currently do not store the `DefId` in the `ConstraintCategory`
	// for performances reasons. The error reporting code used by NLL only
	// uses the span, so this doesn't cause any problems at the moment.

		// Keep this parameter for now, in case we start using
		// it in `ConstraintCategory` at some point.

Uh oh!

Conversation

compiler-errors commented May 10, 2024

Uh oh!

rustbot commented May 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented May 10, 2024

Uh oh!

This comment has been minimized.

bors commented May 10, 2024

Uh oh!

bors commented May 10, 2024

Uh oh!

This comment has been minimized.

rust-timer commented May 10, 2024

Overall result: no relevant changes - no action needed

Uh oh!

compiler-errors commented Jul 16, 2024

Uh oh!

bors commented Jul 17, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Aug 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants