Add and use generics.is_empty() and generics.is_own_empty, rather than using generics' attributes#125006
Conversation
|
HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
compiler-errors
left a comment
There was a problem hiding this comment.
Please fix clippy and rustfmt, otherwise looks fine. I will review again when it's fixed.
633bede to
76eeee1
Compare
Not sure what do you mean by fix clippy. About rustfmt is fixed, didn't realize rustfmt was using |
|
@rustbot review |
|
☔ The latest upstream changes (presumably #125257) made this pull request unmergeable. Please resolve the merge conflicts. |
…n using generics' attributes
76eeee1 to
4501ae8
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1d1283e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.813s -> 668.514s (-0.19%) |
r? @compiler-errors
Related to #123929