Merged
Conversation
Modifying an environment variable would make the function unsafe to call.
…e line In particular, lifetime-generic associated types often have a `where Self: 'a` bound, which we can format on the same line.
Show an example that has bounds.
Suggested-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
…-clause-same-line, r=compiler-errors style-guide: Format single associated type `where` clauses on the same line In particular, lifetime-generic associated types often have a `where Self: 'a` bound, which we can format on the same line.
…ert-label, r=apiraino [meta] Clarify prioritization alert Apparently, there used to exist the label <kbd>I-nominated</kbd> judging from this entry: https://github.com/rust-lang/rust/blob/8847bda592d940ae1f34d87d8cacdc09a9f787fa/triagebot.toml#L393 Since it was replaced with individual team labels, I think it makes sense to update the prioritization alert. Of course, it's not super important since the members of WG-prioritization already know that. This is just cleanup. r? apiraino or wg-prioritization
Stabilize `seek_seek_relative`
This PR stabilizes `seek_seek_relative`:
```rust
// std::io::Seek
trait Seek {
fn seek_relative(&mut self, offset: i64) -> Result<()>;
}
```
<br>
Tracking issue: rust-lang#117374.
Implementation PR: rust-lang#116750.
FCPs already completed in the tracking issue.
Closes rust-lang#117374.
r? libs-api
…lwoerister Don't call `env::set_var` in `rustc_driver::install_ice_hook` Modifying an environment variable would make the function unsafe to call.
…get-spec-json-path, r=jieyouxu Migrate rustdoc target spec json path Part of rust-lang#121876. r? `@jieyouxu`
rustbot
added
A-meta
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 030a12ce2b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (ab14f94): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 677.739s -> 676.19s (-0.23%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
whereclauses on the same line #119515 (style-guide: Format single associated typewhereclauses on the same line)seek_seek_relative#123817 (Stabilizeseek_seek_relative)env::set_varinrustc_driver::install_ice_hook#125063 (Don't callenv::set_varinrustc_driver::install_ice_hook)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup