Rollup of 6 pull requests by matthiaskrgr · Pull Request #125663 · rust-lang/rust

matthiaskrgr · 2024-05-28T15:54:19Z

Successful merges:

NVPTX: Avoid PassMode::Direct for args in C abi #117671 (NVPTX: Avoid PassMode::Direct for args in C abi)
Add an intrinsic for ptr::metadata #124251 (Add an intrinsic for ptr::metadata)
Migrate run-make/allow-warnings-cmdline-stability to rmake.rs #125573 (Migrate run-make/allow-warnings-cmdline-stability to rmake.rs)
Add a "Setup Python" action for github-hosted runners and remove unnecessary CUSTOM_MINGW environment variable #125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary CUSTOM_MINGW environment variable)
Make ProofTreeBuilder actually generic over Interner #125598 (Make ProofTreeBuilder actually generic over Interner)
rustfmt fixes #125637 (rustfmt fixes)

r? @ghost
@rustbot modify labels: rollup

This comment -- "by default we ignore everything in the repository" -- was added in rust-lang#65939 when rustfmt was first being introduced for this repository and (briefly) every directory was ignored. Since then lots of directories have opted in to formatting, so it is no longer true.

Some are too long, some aren't complete sentences, some are complete sentences but don't bother with an upper case letter at the start. All annoying and hurt readability.

It's reasonable to want to, but in the current implementation this causes multiple problems. - All the `rmake.rs` files are formatted every time even when they haven't changed. This is because they get whitelisted unconditionally in the `OverrideBuilder`, before the changed files get added. - The way `OverrideBuilder` works, if any files gets whitelisted then no unmentioned files will get traversed. This is surprising, and means that the `rmake.rs` entries broke the use of explicit paths to `x fmt`, and also broke `GITHUB_ACTIONS=true git check --fmt`. The commit removes the `rmake.rs` entries, fixes the formatting of a couple of files that were misformatted (not previously caught due to the `GITHUB_ACTIONS` breakage), and bans `!`-prefixed entries in `rustfmt.toml` because they cause all these problems.

…ct, r=davidtwco NVPTX: Avoid PassMode::Direct for args in C abi Fixes rust-lang#117480 I must admit that I'm confused about `PassMode` altogether, is there a good sum-up threads for this anywhere? I'm especially confused about how "indirect" and "byval" goes together. To me it seems like "indirect" basically means "use a indirection through a pointer", while "byval" basically means "do not use indirection through a pointer". The return used to keep `PassMode::Direct` for small aggregates. It turns out that `make_indirect` messes up the tests and one way to fix it is to keep `PassMode::Direct` for all aggregates. I have mostly seen this PassMode mentioned for args. Is it also a problem for returns? When experimenting with `byval` as an alternative i ran into [this assert](https://github.com/rust-lang/rust/blob/61a3eea8043cc1c7a09c2adda884e27ffa8a1172/compiler/rustc_codegen_llvm/src/abi.rs#L463C22-L463C22) I have added tests for the same kind of types that is already tested for the "ptx-kernel" abi. The tests cannot be enabled until something like rust-lang#117458 is completed and merged. CC: `@RalfJung` since you seem to be the expert on this and have already helped me out tremendously CC: `@RDambrosio016` in case this influence your work on `rustc_codegen_nvvm` `@rustbot` label +O-NVPTX

Add an intrinsic for `ptr::metadata` The follow-up to rust-lang#123840, so we can remove `PtrComponents` and `PtrRepr` from libcore entirely (well, after a bootstrap update). As discussed in <https://rust-lang.zulipchat.com/#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/.60ptr_metadata.60.20in.20MIR/near/435637808>, this introduces `UnOp::PtrMetadata` taking a raw pointer and returning the associated metadata value. By no longer going through a `union`, this should also help future PRs better optimize pointer operations. r? `@oli-obk`

…ngs-cmdline-stability, r=jieyouxu Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`

Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable The Setup Python action isn't strictly necessary ([even on Windows](rust-lang#125584)) but it is [recommend by GitHub](https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#specifying-a-python-version). The `CUSTOM_MINGW` environment variable is redundant now as it's always set for mingw and always unset otherwise. try-job: x86_64-mingw try-job: x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-mingw

…, r=lcnr Make `ProofTreeBuilder` actually generic over `Interner` Self-explanatory. Also renamed `ecx.tcx()` to `ecx.interner()`. r? lcnr

…aumeGomez rustfmt fixes The `rmake.rs` entries in `rustfmt.toml` are causing major problems for `x fmt`. This PR removes them and does some minor related cleanups. r? `@GuillaumeGomez`

matthiaskrgr · 2024-05-28T15:54:35Z

@bors r+ rollup=never p=6

bors · 2024-05-28T15:54:37Z

📌 Commit 2c7d9ce has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-05-28T15:58:19Z

⌛ Testing commit 2c7d9ce with merge 767e12b...

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#117671 (NVPTX: Avoid PassMode::Direct for args in C abi) - rust-lang#124251 (Add an intrinsic for `ptr::metadata`) - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) - rust-lang#125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable) - rust-lang#125598 (Make `ProofTreeBuilder` actually generic over `Interner`) - rust-lang#125637 (rustfmt fixes) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2024-05-28T16:01:56Z

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'msys2/setup-msys2@v2.22.0' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:a5ac7e51b41094c92402da3b24376905380afc29)
Download action repository 'actions/setup-python@v5' (SHA:82c7e631bb3cdc910f68e0081d67478d79c6982d)
Download action repository 'actions/upload-artifact@v4' (SHA:65462800fd760344b1a7b4382951275a0abb4808)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt \
    && pip3 install virtualenv
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/

# NOTE: intentionally uses python2 for x.py so we can test it still works.
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
           --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
#    pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---

#12 [5/8] COPY host-x86_64/mingw-check/reuse-requirements.txt /tmp/
#12 DONE 0.0s

#13 [6/8] RUN pip3 install --no-deps --no-cache-dir --require-hashes -r /tmp/reuse-requirements.txt     && pip3 install virtualenv
#13 0.406   Downloading binaryornot-0.4.4-py2.py3-none-any.whl (9.0 kB)
#13 0.417 Collecting boolean-py==4.0
#13 0.420   Downloading boolean.py-4.0-py3-none-any.whl (25 kB)
#13 0.433 Collecting chardet==5.1.0
---
#13 3.378 Building wheels for collected packages: reuse
#13 3.379   Building wheel for reuse (pyproject.toml): started
#13 3.702   Building wheel for reuse (pyproject.toml): finished with status 'done'
#13 3.703   Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=181117 sha256=f5f58750481f69515c2c0d1d503daf565e2565c370d07fc6aeb95fe3498b4269
#13 3.703   Stored in directory: /tmp/pip-ephem-wheel-cache-u3aqthnd/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
#13 3.706 Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
#13 3.727   Attempting uninstall: setuptools
#13 3.728     Found existing installation: setuptools 59.6.0
#13 3.729     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.729     Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
#13 3.729     Can't uninstall 'setuptools'. No files were found to uninstall.
#13 4.395 Successfully installed binaryornot-0.4.4 boolean-py-4.0 chardet-5.1.0 jinja2-3.1.2 license-expression-30.0.0 markupsafe-2.1.1 python-debian-0.1.49 reuse-1.1.0 setuptools-66.0.0
#13 4.395 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#13 4.908 Collecting virtualenv
#13 4.946   Downloading virtualenv-20.26.2-py3-none-any.whl (3.9 MB)
#13 4.998      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.9/3.9 MB 77.7 MB/s eta 0:00:00
#13 5.047 Collecting platformdirs<5,>=3.9.1
#13 5.050   Downloading platformdirs-4.2.2-py3-none-any.whl (18 kB)
#13 5.080 Collecting filelock<4,>=3.12.2
#13 5.083   Downloading filelock-3.14.0-py3-none-any.whl (12 kB)
#13 5.099 Collecting distlib<1,>=0.3.7
#13 5.102   Downloading distlib-0.3.8-py2.py3-none-any.whl (468 kB)
#13 5.107      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.9/468.9 KB 118.6 MB/s eta 0:00:00
#13 5.192 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#13 5.355 Successfully installed distlib-0.3.8 filelock-3.14.0 platformdirs-4.2.2 virtualenv-20.26.2
#13 DONE 5.4s

#14 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#14 DONE 0.0s
---
DirectMap4k:      188352 kB
DirectMap2M:     7151616 kB
DirectMap1G:    11534336 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test            --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py:lint
    Finished `dev` profile [unoptimized] target(s) in 0.03s
##[endgroup]
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/f989d2f62500df1696eb797d8800a705293b43b9/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
extracting /checkout/obj/build/cache/llvm-f989d2f62500df1696eb797d8800a705293b43b9-true/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz to /checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished `release` profile [optimized] target(s) in 25.22s
##[endgroup]
fmt check
##[error]Diff in /checkout/compiler/rustc_codegen_cranelift/src/base.rs at line 623:
                         UnOp::Not => {
                             let val = operand.load_scalar(fx);
-                            ty::Bool => {
-                            ty::Bool => {
-                                let res = fx.bcx.ins().icmp_imm(IntCC::Equal, val, 0);
-                                CValue::by_val(res, layout)
+                                ty::Bool => {
+                                    let res = fx.bcx.ins().icmp_imm(IntCC::Equal, val, 0);
+                                    CValue::by_val(res, layout)
+                                }
+                                ty::Uint(_) | ty::Int(_) => {
+                                    CValue::by_val(fx.bcx.ins().bnot(val), layout)
+                                }
+                                _ => unreachable!("un op Not for {:?}", layout.ty),
                             }
-                            ty::Uint(_) | ty::Int(_) => {
-                                CValue::by_val(fx.bcx.ins().bnot(val), layout)
-                            }
-                            _ => unreachable!("un op Not for {:?}", layout.ty),
                         }
                         UnOp::Neg => {
                             let val = operand.load_scalar(fx);
                             let val = operand.load_scalar(fx);
##[error]Diff in /checkout/compiler/rustc_codegen_cranelift/src/base.rs at line 638:
                             match layout.ty.kind() {
-                            ty::Int(_) => CValue::by_val(fx.bcx.ins().ineg(val), layout),
-                            ty::Float(_) => CValue::by_val(fx.bcx.ins().fneg(val), layout),
-                            _ => unreachable!("un op Neg for {:?}", layout.ty),
+                                ty::Int(_) => CValue::by_val(fx.bcx.ins().ineg(val), layout),
+                                ty::Float(_) => CValue::by_val(fx.bcx.ins().fneg(val), layout),
+                                _ => unreachable!("un op Neg for {:?}", layout.ty),
                         }
                         }
                         UnOp::PtrMetadata => match layout.abi {
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_mir_build/src/build/expr/as_rvalue.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/as_place.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/as_temp.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/stmt.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/as_operand.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/category.rs" "/checkout/compiler/rustc_mir_build/src/errors.rs" "/checkout/compiler/rustc_mir_build/src/lints.rs" "/checkout/compiler/rustc_codegen_cranelift/src/pretty_clif.rs" "/checkout/compiler/rustc_codegen_cranelift/src/linkage.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/comments.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/returning.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/pass_mode.rs" "/checkout/compiler/rustc_codegen_cranelift/src/cast.rs" "/checkout/compiler/rustc_codegen_cranelift/src/lib.rs" "/checkout/compiler/rustc_codegen_cranelift/src/trap.rs" "/checkout/compiler/rustc_codegen_cranelift/src/main_shim.rs" "/checkout/compiler/rustc_codegen_cranelift/src/toolchain.rs" "/checkout/compiler/rustc_codegen_cranelift/src/num.rs" "/checkout/compiler/rustc_codegen_cranelift/src/global_asm.rs" "/checkout/compiler/rustc_codegen_cranelift/src/inline_asm.rs" "/checkout/compiler/rustc_codegen_cranelift/src/constant.rs" "/checkout/compiler/rustc_privacy/src/lib.rs" "/checkout/compiler/rustc_privacy/src/errors.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/line_info.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/emit.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/unwind.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/types.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/object.rs" "/checkout/compiler/rustc_codegen_cranelift/src/compiler_builtins.rs" "/checkout/compiler/rustc_codegen_cranelift/src/codegen_i128.rs" "/checkout/compiler/rustc_codegen_cranelift/src/vtable.rs" "/checkout/compiler/rustc_codegen_cranelift/src/analyze.rs" "/checkout/compiler/rustc_codegen_cranelift/src/pointer.rs" "/checkout/compiler/rustc_codegen_cranelift/src/common.rs" "/checkout/compiler/rustc_codegen_cranelift/src/discriminant.rs" "/checkout/compiler/rustc_codegen_cranelift/src/concurrency_limiter.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/jit.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/aot.rs" "/checkout/compiler/rustc_codegen_cranelift/src/archive.rs" "/checkout/compiler/rustc_codegen_cranelift/src/unsize.rs" "/checkout/compiler/rustc_codegen_cranelift/src/base.rs" "/checkout/compiler/rustc_codegen_cranelift/src/value_and_place.rs" "/checkout/compiler/rustc_expand/src/module.rs" "/checkout/compiler/rustc_expand/src/lib.rs" "/checkout/compiler/rustc_expand/src/proc_macro.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm_x86.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/simd.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm_aarch64.rs" "/checkout/compiler/rustc_codegen_cranelift/src/config.rs" "/checkout/compiler/rustc_codegen_cranelift/src/allocator.rs" "/checkout/compiler/rustc_codegen_cranelift/src/optimize/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/optimize/peephole.rs" "/checkout/compiler/rustc_expand/src/mbe/macro_rules.rs" "/checkout/compiler/rustc_expand/src/mbe/macro_parser.rs" "/checkout/compiler/rustc_expand/src/mbe/metavar_expr.rs" "/checkout/compiler/rustc_expand/src/mbe/diagnostics.rs" "/checkout/compiler/rustc_expand/src/mbe/macro_check.rs" "/checkout/compiler/rustc_mir_build/src/build/expr/as_constant.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Tue May 28 15:59:12 UTC 2024
  network time: Tue, 28 May 2024 15:59:12 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rust-log-analyzer · 2024-05-28T16:02:34Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'msys2/setup-msys2@v2.22.0' (SHA:cc11e9188b693c2b100158c3322424c4cc1dadea)
Download action repository 'actions/checkout@v4' (SHA:a5ac7e51b41094c92402da3b24376905380afc29)
Download action repository 'actions/setup-python@v5' (SHA:82c7e631bb3cdc910f68e0081d67478d79c6982d)
Complete job name: auto - aarch64-gnu
##[group]Run git config --global core.autocrlf false
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, source_type: InTree, extra_features: [], allow_features: "" } -- 22.664
[TIMING] core::build_steps::tool::Tidy { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.003
fmt check
##[error]Diff in /checkout/compiler/rustc_codegen_cranelift/src/base.rs at line 623:
                         UnOp::Not => {
                             let val = operand.load_scalar(fx);
-                            ty::Bool => {
-                            ty::Bool => {
-                                let res = fx.bcx.ins().icmp_imm(IntCC::Equal, val, 0);
-                                CValue::by_val(res, layout)
+                                ty::Bool => {
+                                    let res = fx.bcx.ins().icmp_imm(IntCC::Equal, val, 0);
+                                    CValue::by_val(res, layout)
+                                }
+                                ty::Uint(_) | ty::Int(_) => {
+                                    CValue::by_val(fx.bcx.ins().bnot(val), layout)
+                                }
+                                _ => unreachable!("un op Not for {:?}", layout.ty),
                             }
-                            ty::Uint(_) | ty::Int(_) => {
-                                CValue::by_val(fx.bcx.ins().bnot(val), layout)
-                            }
-                            _ => unreachable!("un op Not for {:?}", layout.ty),
                         }
                         UnOp::Neg => {
                             let val = operand.load_scalar(fx);
                             let val = operand.load_scalar(fx);
##[error]Diff in /checkout/compiler/rustc_codegen_cranelift/src/base.rs at line 638:
                             match layout.ty.kind() {
-                            ty::Int(_) => CValue::by_val(fx.bcx.ins().ineg(val), layout),
-                            ty::Float(_) => CValue::by_val(fx.bcx.ins().fneg(val), layout),
-                            _ => unreachable!("un op Neg for {:?}", layout.ty),
+                                ty::Int(_) => CValue::by_val(fx.bcx.ins().ineg(val), layout),
+                                ty::Float(_) => CValue::by_val(fx.bcx.ins().fneg(val), layout),
+                                _ => unreachable!("un op Neg for {:?}", layout.ty),
                         }
                         }
                         UnOp::PtrMetadata => match layout.abi {
Running `"/checkout/obj/build/aarch64-unknown-linux-gnu/rustfmt/bin/rustfmt" "--config-path" "/checkout" "--edition" "2021" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_codegen_cranelift/src/pointer.rs" "/checkout/compiler/rustc_codegen_cranelift/src/toolchain.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/jit.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/driver/aot.rs" "/checkout/compiler/rustc_codegen_cranelift/src/lib.rs" "/checkout/compiler/rustc_codegen_cranelift/src/compiler_builtins.rs" "/checkout/compiler/rustc_codegen_cranelift/src/config.rs" "/checkout/compiler/rustc_codegen_cranelift/src/unsize.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/pass_mode.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/comments.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/abi/returning.rs" "/checkout/compiler/rustc_codegen_cranelift/src/value_and_place.rs" "/checkout/compiler/rustc_codegen_cranelift/src/base.rs" "/checkout/compiler/rustc_codegen_cranelift/src/allocator.rs" "/checkout/compiler/rustc_codegen_cranelift/src/codegen_i128.rs" "/checkout/compiler/rustc_codegen_cranelift/src/main_shim.rs" "/checkout/compiler/rustc_codegen_cranelift/src/vtable.rs" "/checkout/compiler/rustc_codegen_cranelift/src/common.rs" "/checkout/compiler/rustc_codegen_cranelift/src/global_asm.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/unwind.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/types.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/line_info.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/object.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/debuginfo/emit.rs" "/checkout/compiler/rustc_codegen_cranelift/src/constant.rs" "/checkout/compiler/rustc_codegen_cranelift/src/trap.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm_aarch64.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/llvm_x86.rs" "/checkout/compiler/rustc_codegen_cranelift/src/intrinsics/simd.rs" "/checkout/compiler/rustc_codegen_cranelift/src/discriminant.rs" "/checkout/compiler/rustc_codegen_cranelift/src/optimize/peephole.rs" "/checkout/compiler/rustc_codegen_cranelift/src/optimize/mod.rs" "/checkout/compiler/rustc_codegen_cranelift/src/analyze.rs" "/checkout/compiler/rustc_codegen_cranelift/src/linkage.rs" "/checkout/compiler/rustc_codegen_cranelift/src/pretty_clif.rs" "/checkout/compiler/rustc_codegen_cranelift/src/inline_asm.rs" "/checkout/compiler/rustc_mir_transform/src/add_subtyping_projections.rs" "/checkout/compiler/rustc_mir_transform/src/inline.rs" "/checkout/compiler/rustc_mir_transform/src/deduplicate_blocks.rs" "/checkout/compiler/rustc_mir_transform/src/dest_prop.rs" "/checkout/compiler/rustc_mir_transform/src/coroutine.rs" "/checkout/compiler/rustc_mir_transform/src/ffi_unwind_calls.rs" "/checkout/compiler/rustc_mir_transform/src/check_const_item_mutation.rs" "/checkout/compiler/rustc_mir_transform/src/add_retag.rs" "/checkout/compiler/rustc_mir_transform/src/lib.rs" "/checkout/compiler/rustc_mir_transform/src/nrvo.rs" "/checkout/compiler/rustc_mir_transform/src/early_otherwise_branch.rs" "/checkout/compiler/rustc_mir_transform/src/promote_consts.rs" "/checkout/compiler/rustc_mir_transform/src/dead_store_elimination.rs" "/checkout/compiler/rustc_mir_transform/src/simplify.rs" "/checkout/compiler/rustc_mir_transform/src/gvn.rs" "/checkout/compiler/rustc_mir_transform/src/sroa.rs" "/checkout/compiler/rustc_mir_transform/src/shim.rs" "/checkout/compiler/rustc_mir_transform/src/prettify.rs" "/checkout/compiler/rustc_mir_transform/src/unreachable_enum_branching.rs" "/checkout/compiler/rustc_mir_transform/src/dataflow_const_prop.rs" "/checkout/compiler/rustc_mir_transform/src/cost_checker.rs" "/checkout/compiler/rustc_mir_transform/src/const_debuginfo.rs" "/checkout/compiler/rustc_codegen_cranelift/src/cast.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
  local time: Tue May 28 16:02:22 UTC 2024
  network time: Tue, 28 May 2024 16:02:22 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2024-05-28T16:03:06Z

💔 Test failed - checks-actions

Kjetil Kjeka and others added 21 commits May 10, 2024 18:39

NVPTX: Avoid PassMode::Direct for args in C abi

ead02ba

Cleanup custom mingw in CI

f63931b

Add "Setup Python" action to github-hosted runners

19cfe8d

Add an intrinsic for ptr::metadata

ede62b8

Add custom mir support for PtrMetadata

ce8f37b

Add Miri tests for PtrMetadata UB

0f9e4d6

Update description of install-mingw

f931290

Add Miri smoke pass test for ptr_metadata intrinsic

713ddc2

Add assert_not_contains to run-make-support library

5673337

Migrate run-make/allow-warnings-cmdline-stability to rmake.rs

404d47e

Fix comments.

4702a1c

Some are too long, some aren't complete sentences, some are complete sentences but don't bother with an upper case letter at the start. All annoying and hurt readability.

EvalCtxt::tcx() -> EvalCtxt::interner()

50a5da1

Make ProofTreeBuilder actually generic over interner

f494036

Rollup merge of rust-lang#125573 - GuillaumeGomez:migrate-allow-warni…

df3b962

…ngs-cmdline-stability, r=jieyouxu Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`

Rollup merge of rust-lang#125598 - compiler-errors:proof-tree-builder…

87cd582

…, r=lcnr Make `ProofTreeBuilder` actually generic over `Interner` Self-explanatory. Also renamed `ecx.tcx()` to `ecx.interner()`. r? lcnr

Rollup merge of rust-lang#125637 - nnethercote:rustfmt-fixes, r=Guill…

2c7d9ce

…aumeGomez rustfmt fixes The `rmake.rs` entries in `rustfmt.toml` are causing major problems for `x fmt`. This PR removes them and does some minor related cleanups. r? `@GuillaumeGomez`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2024

matthiaskrgr mentioned this pull request May 28, 2024

Add an intrinsic for ptr::metadata #124251

Merged

matthiaskrgr closed this May 28, 2024

matthiaskrgr deleted the rollup-ej3yuxm branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests#125663

Rollup of 6 pull requests#125663
matthiaskrgr wants to merge 21 commits intorust-lang:masterfrom
matthiaskrgr:rollup-ej3yuxm

matthiaskrgr commented May 28, 2024

Uh oh!

matthiaskrgr commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

rust-log-analyzer commented May 28, 2024

Uh oh!

rust-log-analyzer commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

matthiaskrgr commented May 28, 2024

Uh oh!

matthiaskrgr commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

rust-log-analyzer commented May 28, 2024

Uh oh!

rust-log-analyzer commented May 28, 2024

Uh oh!

bors commented May 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants