Add a FCW for special cased blocks#125793
Closed
WaffleLapkin wants to merge 2 commits intorust-lang:masterfrom
Closed
Add a FCW for special cased blocks#125793WaffleLapkin wants to merge 2 commits intorust-lang:masterfrom
WaffleLapkin wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
9 tasks
Contributor
|
This PR shouldn't land anymore since we're no longer changing the diverging behavior, right? |
Member
Author
|
At the very least not in the current form. I think a warning could be good, but not as a warn-by-default FCW. |
WaffleLapkin
added
S-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i.e. the #123590 change.
I can't seem to figure out how to make the lint work for
panic!();, because the span of the statement does not include the;(something weird going on in macro expansion)...Other than that the lint is basically done.
Although this PR also requires changing std, so it doesn't error...
Tracking:
r? @compiler-errors