Open
Conversation
Collaborator
rustbot
added
S-waiting-on-review
the8472
reviewed
Jun 6, 2024
scottmcm
added
S-waiting-on-author
Member
|
Hi @scottmcm, ping from triage team. Are there any further updates on this PR? |
scottmcm
force-pushed
the
decaveat-map
branch
from
30e79db to
a0fd77c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Thanks to 107634 and some improvements in LLVM (particularly `dead_on_unwind`), the method actually optimizes reasonably well now. So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and encouraging `Iterator::map` where an array wasn't actually ever needed.
scottmcm
force-pushed
the
decaveat-map
branch
from
a0fd77c to
bdc08ae
Compare
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 8, 2026
…lacrum Reword the caveats on `array::map` Thanks to rust-lang#107634 and some improvements in LLVM (particularly [`dead_on_unwind`](https://llvm.org/docs/LangRef.html#parameter-attributes)), the method actually optimizes reasonably well now. So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and keep encouraging `Iterator::map` where an array wasn't actually ever needed.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 8, 2026
…lacrum Reword the caveats on `array::map` Thanks to rust-lang#107634 and some improvements in LLVM (particularly [`dead_on_unwind`](https://llvm.org/docs/LangRef.html#parameter-attributes)), the method actually optimizes reasonably well now. So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and keep encouraging `Iterator::map` where an array wasn't actually ever needed.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2026
…uwer Rollup of 5 pull requests Successful merges: - #151869 (add test for codegen of SIMD vector from array repeat) - #152077 (bootstrap: always propagate `CARGO_TARGET_{host}_LINKER`) - #126100 (Reword the caveats on `array::map`) - #152275 (Stop having two different alignment constants) - #152325 (Remove more adhoc groups that correspond to teams)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to #107634 and some improvements in LLVM (particularly
dead_on_unwind), the method actually optimizes reasonably well now.So focus the discussion on the fundamental ordering differences where the optimizer might never be able to fix it because of the different behaviour, and keep encouraging
Iterator::mapwhere an array wasn't actually ever needed.