tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs#126137
tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs#126137bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
This probably shouldn't be added as a test, since it's exercising behavior that we may not expect to work on the new trait solver. Type inferfence in higher-ranked associated types is kinda busted.
If you really want to add this test, then you should probably add two explicit revisions for the old and new trait solver. Grep the ui test suite for some lines to steal: //@ revisions: current next.
Also, this test name is not really complete. It should mention something like higher-ranked. Maybe rigid-equate-projections-in-higher-ranked-fn-signature.
Enselic
force-pushed
the
normalize-generic-arg
branch
from
238fcba to
1293ef7
Compare
My main goal is to close #107564. Personally I'm completely fine with closing it with motivation "we don't want a test for this case". But for now I updated the test.
Done!
I thought it was sufficient that it was put in a dir called higher-ranked. But your name is much better than mine regardless. Done! |
| //@[next] check-fail | ||
| //@ ignore-compare-mode-next-solver (explicit revisions) | ||
|
|
||
| /// This triggers an ICE with (and without) `--emit metadata` using the old |
There was a problem hiding this comment.
(minor) either // (preferably) or //!. rn, this is "documenting" the trait, not the crate
|
@bors r+ |
|
@bors rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#126137 (tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs) - rust-lang#126146 (std::unix::process adding few specific freebsd signals to be able to id.) - rust-lang#126155 (Remove empty test suite `tests/run-make-fulldeps`) - rust-lang#126168 (std::unix::os current_exe implementation simplification for haiku.) - rust-lang#126175 (Use --quiet flag when installing pip dependencies) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126137 - Enselic:normalize-generic-arg, r=compiler-errors tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs This adds a regression test for an ICE "accidentally" fixed by rust-lang#101947 that does not add a test for this particular case. Closes rust-lang#107564. I have confirmed the added test code fails with `nightly-2023-01-09` (and passes with `nightly-2023-01-10` and of course recent `nightly`).
6 participants
This adds a regression test for an ICE "accidentally" fixed by #101947 that does not add a test for this particular case.
Closes #107564.
I have confirmed the added test code fails with
nightly-2023-01-09(and passes withnightly-2023-01-10and of course recentnightly).