Closed
Conversation
Collaborator
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #128334) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@pietroalbini |
Merged
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 14, 2024
add ./x clippy ci This is rebase of rust-lang#126321 also https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/enable.20more.20clippy.20lints.20for.20compiler.20.28and.5Cor.20std.29 for context
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 14, 2024
add ./x clippy ci This is rebase of rust-lang#126321 also https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/enable.20more.20clippy.20lints.20for.20compiler.20.28and.5Cor.20std.29 for context
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2024
Rollup merge of rust-lang#132649 - klensy:pa-clippy-ci, r=onur-ozkan add ./x clippy ci This is rebase of rust-lang#126321 also https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/enable.20more.20clippy.20lints.20for.20compiler.20.28and.5Cor.20std.29 for context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mingw-checkjob runs some Clippy lints with custom-Dand-Aflags, and that is annoying when trying to reproduce that behavior locally. The only way to reproduce what CI is doing today is to go look at the dockerfile for that job, and that is far from ideal.This came up when doing the stage0 bump to 1.80.0 (#126273), as during stage0 bumps we get the new Clippy lints for the release. We don't want to update the release process instructions every single time something changes in the CI configuration, but rather I'd like a single command I can put in the instructions to check for newly introduced Clippy lints.
This PR adds that: the new
./x clippy cidoes what we do today in our CI, and the PR switches themingw-checkjob to run that command.