Delegation: support coercion for target expression by Bryanskiy · Pull Request #126699 · rust-lang/rust

Bryanskiy · 2024-06-19T16:44:21Z

The implementation consist of 2 parts. Firstly, method call is generated instead of fully qualified call in AST->HIR lowering if there were no generic arguments or Qpath were provided. These restrictions are imposed due to the loss of information after desugaring. For example in

trait Trait {
  fn foo(&self) {}
}

reuse <u8 as Trait>::foo;

We would like to generate such a code:

fn foo<u8: Trait>(x: &u8) {
  x.foo(x)
}

however, the signature is inherited during HIR analysis where u8 was discarded.

Then, we probe the single pre-resolved method.

P.S In the future, we would like to avoid restrictions on the callee path by Self autoref/autoderef in fully qualified calls, but at the moment it didn't work out.

r? @petrochenkov

Bryanskiy · 2024-06-19T16:59:34Z

@rustbot author

Bryanskiy · 2024-06-24T16:02:52Z

@rustbot ready

tests/ui/delegation/glob-glob.rs

compiler/rustc_resolve/src/late.rs

compiler/rustc_hir_typeck/src/method/probe.rs

compiler/rustc_ast_lowering/src/delegation.rs

petrochenkov · 2024-06-25T10:57:37Z

The PR needs a high level description - how exactly does it solve #118212 (comment) (in a few sentences).
@rustbot author

…ctoring, r=petrochenkov Delegation: ast lowering refactor refactoring changes for rust-lang#126699 r? `@petrochenkov`

…ctoring, r=petrochenkov Delegation: ast lowering refactor refactoring changes for rust-lang#126699 r? ``@petrochenkov``

…ctoring, r=petrochenkov Delegation: ast lowering refactor refactoring changes for rust-lang#126699 r? ```@petrochenkov```

Rollup merge of rust-lang#126947 - Bryanskiy:delegation-lowering-refactoring, r=petrochenkov Delegation: ast lowering refactor refactoring changes for rust-lang#126699 r? ```@petrochenkov```

Bryanskiy · 2024-06-27T15:28:45Z

@rustbot ready

tests/ui/delegation/method-call-priority.rs

tests/ui/delegation/target-expr.rs

compiler/rustc_resolve/src/late.rs

compiler/rustc_hir_typeck/src/method/probe.rs

compiler/rustc_ast_lowering/src/delegation.rs

compiler-errors

See comments.

petrochenkov · 2024-07-16T13:45:46Z

r? @compiler-errors

Bryanskiy · 2024-07-16T14:39:34Z

@rustbot ready

compiler/rustc_hir_typeck/src/method/mod.rs

compiler-errors · 2024-07-16T14:52:28Z

r=me after the nit

Bryanskiy · 2024-07-16T15:21:12Z

@bors r=compiler-errors

bors · 2024-07-16T15:21:14Z

@Bryanskiy: 🔑 Insufficient privileges: Not in reviewers

compiler-errors · 2024-07-16T15:22:49Z

@bors r=compiler-errors,petrochenkov

petrochenkov · 2024-07-16T15:22:50Z

@bors r=compiler-errors

bors · 2024-07-16T15:22:51Z

📌 Commit 7ee97f9 has been approved by compiler-errors,petrochenkov

It is now in the queue for this repository.

bors · 2024-07-16T15:22:53Z

📌 Commit 7ee97f9 has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2024-07-16T15:22:58Z

lol race condition

Rollup of 7 pull requests Successful merges: - rust-lang#124033 (Sync ar_archive_writer to LLVM 18.1.3) - rust-lang#126699 (Delegation: support coercion for target expression) - rust-lang#126762 (Deny keyword lifetimes pre-expansion) - rust-lang#126967 (Promote the `wasm32-wasip2` target to Tier 2) - rust-lang#127390 (Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake) - rust-lang#127501 (Invert infer `error_reporting` mod struture) - rust-lang#127816 (Update method name to reflect changes to its internals) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126699 - Bryanskiy:delegation-coercion, r=compiler-errors Delegation: support coercion for target expression (solves rust-lang#118212 (comment)) The implementation consist of 2 parts. Firstly, method call is generated instead of fully qualified call in AST->HIR lowering if there were no generic arguments or `Qpath` were provided. These restrictions are imposed due to the loss of information after desugaring. For example in ```rust trait Trait { fn foo(&self) {} } reuse <u8 as Trait>::foo; ``` We would like to generate such a code: ```rust fn foo<u8: Trait>(x: &u8) { x.foo(x) } ``` however, the signature is inherited during HIR analysis where `u8` was discarded. Then, we probe the single pre-resolved method. P.S In the future, we would like to avoid restrictions on the callee path by `Self` autoref/autoderef in fully qualified calls, but at the moment it didn't work out. r? `@petrochenkov`

spastorino · 2024-07-17T17:50:36Z

Thanks for taking over this and sorry for not being able to look at this on time.

rustbot assigned petrochenkov Jun 19, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024

petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jun 24, 2024

petrochenkov mentioned this pull request Jun 24, 2024

Tracking Issue for function delegation (fn_delegation, RFC 3530) #118212

Open

29 tasks

Bryanskiy force-pushed the delegation-coercion branch from de488f2 to 1e5a473 Compare June 24, 2024 15:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2024

petrochenkov reviewed Jun 25, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2024

Bryanskiy mentioned this pull request Jun 25, 2024

Delegation: ast lowering refactor #126947

Merged

This comment was marked as resolved.

Sign in to view

Bryanskiy force-pushed the delegation-coercion branch from 1e5a473 to 64d78b4 Compare June 27, 2024 14:22

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2024

petrochenkov reviewed Jun 28, 2024

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024

Bryanskiy force-pushed the delegation-coercion branch from 64d78b4 to 02a1f30 Compare June 28, 2024 14:31

compiler-errors suggested changes Jul 15, 2024

View reviewed changes

Bryanskiy force-pushed the delegation-coercion branch from 9568e12 to 784f358 Compare July 16, 2024 13:38

petrochenkov approved these changes Jul 16, 2024

View reviewed changes

rustbot assigned compiler-errors and unassigned petrochenkov Jul 16, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2024

compiler-errors approved these changes Jul 16, 2024

View reviewed changes

compiler/rustc_hir_typeck/src/method/mod.rs Outdated Show resolved Hide resolved

Delegation: support coercion for target expression

7ee97f9

Bryanskiy force-pushed the delegation-coercion branch from 784f358 to 7ee97f9 Compare July 16, 2024 15:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024

tgross35 mentioned this pull request Jul 16, 2024

Rollup of 7 pull requests #127831

Merged

bors merged commit 36ea068 into rust-lang:master Jul 17, 2024

rustbot added this to the 1.81.0 milestone Jul 17, 2024

GrigorenkoPV mentioned this pull request Jul 18, 2024

ICE: delegation: unexpected parent of trait or impl item or item not found #127916

Closed

GrigorenkoPV mentioned this pull request Jul 27, 2024

ICE: expected item, found (root_crate) #128190

Closed

Uh oh!

Conversation

Bryanskiy commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bryanskiy commented Jun 19, 2024

Uh oh!

Bryanskiy commented Jun 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jun 25, 2024

Uh oh!

This comment was marked as resolved.

Bryanskiy commented Jun 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Jul 16, 2024

Uh oh!

Bryanskiy commented Jul 16, 2024

Uh oh!

Uh oh!

compiler-errors commented Jul 16, 2024

Uh oh!

Bryanskiy commented Jul 16, 2024

Uh oh!

bors commented Jul 16, 2024

Uh oh!

compiler-errors commented Jul 16, 2024

Uh oh!

petrochenkov commented Jul 16, 2024

Uh oh!

bors commented Jul 16, 2024

Uh oh!

bors commented Jul 16, 2024

Uh oh!

compiler-errors commented Jul 16, 2024

Uh oh!

spastorino commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Bryanskiy commented Jun 19, 2024 •

edited

Loading