Switch back `non_local_definitions` lint to allow-by-default by Urgau · Pull Request #127015 · rust-lang/rust

Urgau · 2024-06-27T06:07:39Z

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in #126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

Tracking:

Tracking Issue for RFC 3373: Avoid non-local definitions in functions #120363

as request T-lang is requesting some major changes in the lint inner workings in rust-lang#126768#issuecomment-2192634762

rustbot · 2024-06-27T06:07:46Z

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lqd · 2024-06-27T06:58:25Z

r=me when CI is green

lqd · 2024-06-27T07:02:19Z

What’s the PR that made this specific case warn? Was it #120393 as that landed 2 releases ago. If so, we could also nominate for a stable backport in case a point release happens.

Urgau · 2024-06-27T07:13:04Z

yes it was #120393 but since then the implementation was already changed and improved quite a bit, leading to the lint not currently being warn-by-default in any stable releases, one can check that by looking at the current allow-by-default list of current stable

Urgau · 2024-06-27T07:13:38Z

@bors r=lqd rollup

bors · 2024-06-27T07:13:41Z

📌 Commit 0c0dfb8 has been approved by lqd

It is now in the queue for this repository.

lqd · 2024-06-27T07:41:10Z

leading to the lint not currently being warn-by-default in any stable releases

To make the backport request a bit clearer to people, could you list how? The lint was made warn-by-default in 2f2d5cc so this PR basically reverts that, was it not registered as a lint or what else did not make it the default when that landed in 1.79?

So the PR causing #126768 is not only #120393 but some combination with #122747 and unknown others that are only on beta right now, and this PR will effectively prevent that from landing on stable.

Urgau · 2024-06-27T07:51:33Z

it was put back to allow-by-default in #125183 for 1.79, but left as warn-by-default in 1.80, this PR would make it allow in 1.81 and the backport would make it allow in 1.80

So the PR causing #126768 is not only #120393 but some combination with #122747 and unknown others that are only on beta right now, and this PR will effectively prevent that from landing on stable.

not really, we improved the rules with #122747 but the "root" cause is still the original impl #126768

lqd · 2024-06-27T08:10:47Z

So to answer the question of how we don't have problems on stable is because cfae8b2 prevented the lint from being enabled there, despite being warn-by-default on master. This is clearer, thank you.

michaelwoerister · 2024-06-27T09:16:51Z

r? @lqd

Switch back `non_local_definitions` lint to allow-by-default This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment). This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127010 (Update browser-ui-test version to `0.18.0`) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

Switch back `non_local_definitions` lint to allow-by-default This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment). This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127010 (Update browser-ui-test version to `0.18.0`) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

Switch back `non_local_definitions` lint to allow-by-default This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment). This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

Switch back `non_local_definitions` lint to allow-by-default This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment). This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) - rust-lang#127041 (Migrate `run-make/override-aliased-flags` to `rmake.rs`) - rust-lang#127045 (Rename `super_predicates_of` and similar queries to `explicit_*` to note that they're not elaborated) - rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#126835 (Simplifications in match lowering) - rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#123714 (Add test for fn pointer duplication.) - rust-lang#124091 (Update AST validation module docs) - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) - rust-lang#127016 (docs: check if the disambiguator matches its suffix) - rust-lang#127029 (Fix Markdown tables in platform-support.md) - rust-lang#127032 (Enable const casting for `f16` and `f128`) - rust-lang#127055 (Mark Hasher::finish as #[must_use]) - rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params) - rust-lang#127070 (add () to the marker_impls macro for ConstParamTy) - rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods) - rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127015 - Urgau:non_local_def-tmp-allow, r=lqd Switch back `non_local_definitions` lint to allow-by-default This PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment). This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

apiraino · 2024-07-04T14:30:58Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

[beta] backports - Properly gate `safe` keyword in pre-expansion rust-lang#126757 - Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015 - Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068 - Update LLVM submodule rust-lang#127190 r? cuviper

[beta] backports - Properly gate `safe` keyword in pre-expansion rust-lang#126757 - Switch back `non_local_definitions` lint to allow-by-default rust-lang#127015 - Stall computing instance for drop shim until it has no unsubstituted const params rust-lang#127068 - Update LLVM submodule rust-lang#127190 - Change to the NetBSD archive URL rather than the CDN rust-lang#127232 r? cuviper

Switch back non_local_definitions lint to allow-by-default

0c0dfb8

as request T-lang is requesting some major changes in the lint inner workings in rust-lang#126768#issuecomment-2192634762

rustbot assigned michaelwoerister Jun 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 27, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2024

workingjubilee added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 27, 2024

Noratrieb removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 27, 2024

workingjubilee added the L-non_local_definitions Lint: non_local_definitions label Jun 27, 2024

rustbot assigned lqd and unassigned michaelwoerister Jun 27, 2024

GuillaumeGomez mentioned this pull request Jun 27, 2024

Rollup of 10 pull requests #127046

Closed

matthiaskrgr mentioned this pull request Jun 27, 2024

Rollup of 9 pull requests #127056

Closed

jhpratt mentioned this pull request Jun 28, 2024

Rollup of 12 pull requests #127064

Closed

matthiaskrgr mentioned this pull request Jun 28, 2024

Rollup of 8 pull requests #127066

Closed

GuillaumeGomez mentioned this pull request Jun 28, 2024

Rollup of 10 pull requests #127079

Closed

matthiaskrgr mentioned this pull request Jun 28, 2024

Rollup of 11 pull requests #127096

Merged

bors merged commit 3f560af into rust-lang:master Jun 29, 2024

rustbot added this to the 1.81.0 milestone Jun 29, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 4, 2024

cuviper mentioned this pull request Jul 5, 2024

[beta] backports #127377

Merged

cuviper modified the milestones: 1.81.0, 1.80.0 Jul 5, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 5, 2024

This was referenced Jul 11, 2024

Tracking Issue for RFC 3373: Avoid non-local definitions in functions #120363

Closed

non_local_definitions lint fires for impl Trait for NonLocalType<SomeLocalType>, probably shouldn't #126768

Closed

ogoffart mentioned this pull request Sep 25, 2024

Please make a new release on crate.io to fix non_local_definitions warning Diggsey/scoped-tls-hkt#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Switch back `non_local_definitions` lint to allow-by-default#127015

Switch back `non_local_definitions` lint to allow-by-default#127015
bors merged 1 commit intorust-lang:masterfrom
Urgau:non_local_def-tmp-allow

Urgau commented Jun 27, 2024 •

edited by traviscross

Loading

Uh oh!

rustbot commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024 •

edited

Loading

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

michaelwoerister commented Jun 27, 2024

Uh oh!

apiraino commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Urgau commented Jun 27, 2024 • edited by traviscross Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024

Uh oh!

bors commented Jun 27, 2024

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

Urgau commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lqd commented Jun 27, 2024

Uh oh!

michaelwoerister commented Jun 27, 2024

Uh oh!

apiraino commented Jul 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Urgau commented Jun 27, 2024 •

edited by traviscross

Loading

Urgau commented Jun 27, 2024 •

edited

Loading