doc: update config file path in platform-support/wasm32-wasip1-threads.md#127236
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 7, 2024
Merged
doc: update config file path in platform-support/wasm32-wasip1-threads.md#127236bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
Member
|
r? Nilstrieb |
Member
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127179 (Print `TypeId` as hex for debugging) - rust-lang#127189 (LinkedList's Cursor: method to get a ref to the cursor's list) - rust-lang#127236 (doc: update config file path in platform-support/wasm32-wasip1-threads.md) - rust-lang#127297 (Improve std::Path's Hash quality by avoiding prefix collisions) - rust-lang#127308 (Attribute cleanups) - rust-lang#127354 (Describe Sized requirements for mem::offset_of) - rust-lang#127409 (Emit a wrap expr span_bug only if context is not tainted) - rust-lang#127447 (once_lock: make test not take as long in Miri) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 7, 2024
Rollup merge of rust-lang#127236 - iawia002:wasip1-threads-doc, r=Nilstrieb doc: update config file path in platform-support/wasm32-wasip1-threads.md The config content described in the `Building the target` section should be the configuration used for building Rust itself: https://github.com/rust-lang/rust/blob/7d97c59438e933e86f557ed999da3b8dfc6855a7/config.example.toml#L845-L848 I believe this is different from Cargo's configuration. There seems to be some misunderstanding in the discussion here: rust-lang#112922 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config content described in the
Building the targetsection should be the configuration used for building Rust itself:rust/config.example.toml
Lines 845 to 848 in 7d97c59
I believe this is different from Cargo's configuration. There seems to be some misunderstanding in the discussion here: #112922 (comment).