Suggest removing .unwrap() or .expect() if followed by a failed ? operator#127485
Closed
trevyn wants to merge 1 commit intorust-lang:masterfrom
Closed
Suggest removing .unwrap() or .expect() if followed by a failed ? operator#127485trevyn wants to merge 1 commit intorust-lang:masterfrom
.unwrap() or .expect() if followed by a failed ? operator#127485trevyn wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #127493) made this pull request unmergeable. Please resolve the merge conflicts. |
fee1-dead
requested changes
Jul 10, 2024
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Show resolved
Hide resolved
rustbot
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
fee1-dead
reviewed
Jul 12, 2024
fee1-dead
requested changes
Jul 15, 2024
Comment on lines
+34
to
+39
| fn baz3() -> Option<usize> { | ||
| Ok(44).unwrap()? | ||
| //~^ ERROR the `?` operator can only be applied to values that implement `Try` | ||
| //~| HELP the trait `Try` is not implemented for `{integer}` | ||
| //~| HELP remove the `.unwrap()` | ||
| } |
Member
There was a problem hiding this comment.
In baz3 the suggestion shouldn't fire because removing the .unwrap does not help. You probably want to check that the return type of the function is compatible with the non-unwrapped reciever
Comment on lines
+41
to
+48
| fn baz4() { | ||
| Ok(44).unwrap()? | ||
| //~^ ERROR the `?` operator can only be applied to values that implement `Try` | ||
| //~| HELP the trait `Try` is not implemented for `{integer}` | ||
| //~| HELP remove the `.unwrap()` | ||
| //~| ERROR the `?` operator can only be used in a function that returns `Result` or `Option` (or another type that implements `FromResidual`) | ||
| //~| HELP the trait `FromResidual<_>` is not implemented for `()` | ||
| } |
Member
There was a problem hiding this comment.
Same here. It is more likely that the ? was inserted on error and not .unwrap()
rustbot
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #128041) made this pull request unmergeable. Please resolve the merge conflicts. |
lolbinarycat
added
the
A-diagnostics
Member
|
@trevyn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127345