Skip to content

Make DropShim's param_env optional to fix InstanceKind::DropShim #127815

Closed
compiler-errors wants to merge 2 commits intorust-lang:masterfrom
compiler-errors:drop
Closed

Make DropShim's param_env optional to fix InstanceKind::DropShim #127815
compiler-errors wants to merge 2 commits intorust-lang:masterfrom
compiler-errors:drop

Conversation

@compiler-errors
Copy link
Contributor

@compiler-errors compiler-errors commented Jul 16, 2024

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2024
@compiler-errors
Copy link
Contributor Author

compiler-errors commented Jul 16, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2024
@bors
Auto merge of rust-lang#127815 - compiler-errors:drop, r=<try>
dd9e5ad 
Make `DropShim`'s `param_env` optional to fix `InstanceKind::DropShim`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jul 16, 2024

⌛ Trying commit 41c8e75 with merge dd9e5ad...

@bors
Copy link
Collaborator

bors commented Jul 16, 2024

☀️ Try build successful - checks-actions
Build commit: dd9e5ad (dd9e5adc6153c7c222a1923fa82bb5c2c1fb767c)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 16, 2024

Finished benchmarking commit (dd9e5ad): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 700.14s -> 701.111s (0.14%)
Artifact size: 328.63 MiB -> 328.55 MiB (-0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 16, 2024
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2024
@bors
Copy link
Collaborator

bors commented Sep 9, 2024

☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors @rust-timer @bors @rustbot @Dylan-DPC