Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake by Oneirical · Pull Request #127872 · rust-lang/rust

Oneirical · 2024-07-17T20:09:33Z

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: x86_64-msvc
try-job: i686-mingw
try-job: aarch64-apple

rustbot · 2024-07-17T20:09:41Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-17T20:09:43Z

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

tgross35 · 2024-07-17T20:43:12Z

@bors try

Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-apple

bors · 2024-07-17T20:44:23Z

⌛ Trying commit 0fa1214 with merge 0fdfa4c...

tgross35 · 2024-07-17T20:50:32Z

src/tools/run-make-support/src/external_deps/c_build.rs

+    } else {
+        cc().arg("-v").arg("-c").out_exe(&obj_file).input(src).run();
+    };
+    let obj_file = if is_msvc() { format!("{lib_name}.obj") } else { format!("{lib_name}.o") };


Obviously not a job for here, but maybe run-make should switch from a &str-based API to Path-based so these turn into e.g. path_buf.set_extension(...) and path.extension().unwrap(), rather than manipulating the strings directly. And then just take impl AsRef<OsStr> everywhere so &str still works.

Yeah, feel free to leave a FIXME here for me.

bors · 2024-07-17T21:49:18Z

💔 Test failed - checks-actions

src/tools/run-make-support/src/external_deps/c_build.rs

jieyouxu · 2024-07-18T02:21:41Z

Need to take a look at this.
@rustbot review

jieyouxu · 2024-07-18T03:23:58Z

@rustbot author (pls flip when ready)

Oneirical · 2024-07-18T13:26:02Z

@bors try (no permissions, please do it)
@rustbot review

bors · 2024-07-18T13:26:04Z

@Oneirical: 🔑 Insufficient privileges: not in try users

jieyouxu

Thanks

jieyouxu · 2024-07-22T17:34:36Z

@bors r+ rollup=iffy (c native libs and linkage tests)

bors · 2024-07-22T17:34:39Z

📌 Commit 2e3470e has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-apple

bors · 2024-07-23T04:19:20Z

⌛ Testing commit 2e3470e with merge d8c4e27...

bors · 2024-07-23T05:38:08Z

💔 Test failed - checks-actions

jieyouxu · 2024-07-23T08:04:14Z

Doc typo: DLL_PERFIX

jieyouxu · 2024-07-23T08:04:20Z

@rustbot author

Oneirical · 2024-07-23T14:31:33Z

Doc typo: DLL_PERFIX

Hehe, I blame the copypaste! It's good that it was in a doc link, that way CI caught it.

@rustbot review, please re-approve

jieyouxu · 2024-07-23T17:54:43Z

Thanks! @bors r+

bors · 2024-07-23T17:54:46Z

📌 Commit 710e7b0 has been approved by jieyouxu

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#127054 (Reorder trait bound modifiers *after* `for<...>` binder in trait bounds) - rust-lang#127528 (Replace ASCII control chars with Unicode Control Pictures) - rust-lang#127872 (Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake) - rust-lang#128111 (Do not use question as label) - rust-lang#128160 (Don't ICE when auto trait has assoc ty in old solver) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127872 - Oneirical:antestral-traditions, r=jieyouxu Migrate `pointer-auth-link-with-c`, `c-dynamic-rlib` and `c-dynamic-dylib` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Please try: try-job: x86_64-msvc try-job: i686-mingw try-job: aarch64-apple

rustbot assigned jieyouxu Jul 17, 2024

This comment has been minimized.

Sign in to view

Oneirical force-pushed the antestral-traditions branch from 2983350 to 0fa1214 Compare July 17, 2024 20:24

tgross35 reviewed Jul 17, 2024

View reviewed changes

Kobzol mentioned this pull request Jul 17, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2024

jieyouxu reviewed Jul 18, 2024

View reviewed changes

src/tools/run-make-support/src/external_deps/c_build.rs Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2024

Oneirical force-pushed the antestral-traditions branch from 0fa1214 to 96d6694 Compare July 18, 2024 13:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2024

jieyouxu approved these changes Jul 22, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2024

rewrite c-dynamic-dylib to rmake

710e7b0

Oneirical force-pushed the antestral-traditions branch from 2e3470e to 710e7b0 Compare July 23, 2024 14:31

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2024

matthiaskrgr mentioned this pull request Jul 25, 2024

Rollup of 5 pull requests #128169

Merged

bors merged commit 04e4569 into rust-lang:master Jul 25, 2024

rustbot added this to the 1.82.0 milestone Jul 25, 2024

Uh oh!

Conversation

Oneirical commented Jul 17, 2024

Uh oh!

rustbot commented Jul 17, 2024

Uh oh!

rustbot commented Jul 17, 2024

Uh oh!

This comment has been minimized.

tgross35 commented Jul 17, 2024

Uh oh!

bors commented Jul 17, 2024

Uh oh!

tgross35 Jul 17, 2024

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 18, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

bors commented Jul 17, 2024

Uh oh!

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

jieyouxu commented Jul 18, 2024

Uh oh!

Oneirical commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 18, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 22, 2024

Uh oh!

bors commented Jul 22, 2024

Uh oh!

bors commented Jul 23, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 23, 2024

Uh oh!

jieyouxu commented Jul 23, 2024

Uh oh!

jieyouxu commented Jul 23, 2024

Uh oh!

Oneirical commented Jul 23, 2024

Uh oh!

jieyouxu commented Jul 23, 2024

Uh oh!

bors commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Oneirical commented Jul 18, 2024 •

edited

Loading